chore(batcher): unify client implementations

[Itay-Tsabary-Starkware]

Stack:

• chore(sequencer_infra): remove redundant clones #2119
• refactor: rename generic param in client trait impl #2115
• chore(mempool_types): unify client implementations #2090
• chore(mempool_p2p_types): unify client implementations #2089
• chore(gateway): unify client implementations #2088
• chore(sequencer_infra): restructure code to avoid clone trait bound #2087
• chore(batcher): unify client implementations #2086 ⬅
• chore(sequencer_infra): add component client trait for remote client #2085

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.06%. Comparing base (05aa17c) to head (1d5ae1f).

Additional details and impacted files

@@                  Coverage Diff                  @@
##           spr/main/5b800b4d   #2086       +/-   ##
=====================================================
- Coverage              55.82%   5.06%   -50.76%     
=====================================================
  Files                      8     141      +133     
  Lines                    292   16885    +16593     
  Branches                 292   16885    +16593     
=====================================================
+ Hits                     163     856      +693     
- Misses                   115   15957    +15842     
- Partials                  14      72       +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nadin-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_batcher_types/src/communication.rs line 103 at r1 (raw file):

#[async_trait]
impl<T> BatcherClient for T

Please replace T with a more descriptive name, such as ClientType or something similar.

Code quote:

T

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)

---

crates/starknet_batcher_types/src/communication.rs line 103 at r1 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Please replace T with a more descriptive name, such as ClientType or something similar.

As a single pr at the end 🙏

[nadin-Starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

✓ Commit merged in pull request #2119