feat(blockifier): keep revert error structure in TransactionExecutionInfo

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(blockifier): keep revert error structure in TransactionExecutionInfo #1491 👈 (View in Graphite)
• feat(blockifier): cairo1 revert stack now part of ErrorStack #1490
• test(blockifier): test negative flows of cairo1 revert trace #1469
• feat(blockifier): limit characters in cairo1 revert trace #1468
• feat(blockifier): structured cairo1 stack trace #1461
• test(blockifier): add class hash (if set) to cairo1 revert trace #1460
• feat(blockifier): add address and selector for intermediate cairo1 revert errors #1459
• test(blockifier): named values in test #1458
• refactor(blockifier): format retdata in ExecutionFailed and PanicInValidate errors #1457
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewable status: 0 of 15 files reviewed, all discussions resolved

---

crates/blockifier/src/transaction/objects.rs line 166 at r1 (raw file):

        Self::Execution(ErrorStack::default())
    }
}

required, since TransactionExecutionInfo must implement Default.
This won't really be used (Option default is None)

Code quote:

impl Default for RevertError {
    fn default() -> Self {
        Self::Execution(ErrorStack::default())
    }
}

[codecov]

Codecov Report

Attention: Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.41%. Comparing base (e3165c4) to head (9e44467).
Report is 418 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/execution/stack_trace.rs	96.15%	1 Missing ⚠️
crates/native_blockifier/src/py_block_executor.rs	0.00%	1 Missing ⚠️
crates/papyrus_execution/src/objects.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1491       +/-   ##
===========================================
+ Coverage   40.10%   61.41%   +21.31%     
===========================================
  Files          26      175      +149     
  Lines        1895    20349    +18454     
  Branches     1895    20349    +18454     
===========================================
+ Hits          760    12498    +11738     
- Misses       1100     6954     +5854     
- Partials       35      897      +862     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[ilyalesokhin-starkware]

crates/blockifier/src/transaction/objects.rs line 166 at r1 (raw file):

Previously, dorimedini-starkware wrote…

required, since TransactionExecutionInfo must implement Default.
This won't really be used (Option default is None)

you could make it optional

[ilyalesokhin-starkware]

Reviewed 2 of 15 files at r1, 1 of 11 files at r2, 1 of 9 files at r4.
Reviewable status: 3 of 15 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

---

crates/blockifier/src/transaction/objects.rs line 166 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

you could make it optional

Actually, I see that it is optional, so why do you need a default?

[github-actions]

Artifacts upload triggered. View details here

[dorimedini-starkware]

Reviewable status: 2 of 15 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @ilyalesokhin-starkware)

---

crates/blockifier/src/transaction/objects.rs line 166 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

Actually, I see that it is optional, so why do you need a default?

I thought I did, I was wrong :) fixed

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[ilyalesokhin-starkware]

Reviewed 16 of 16 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[dorimedini-starkware]

Reviewed 4 of 4 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

[dorimedini-starkware]

Merge activity

• Nov 17, 5:09 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Nov 17, 5:11 AM EST: Graphite rebased this pull request as part of a merge.
• Nov 17, 5:31 AM EST: A user merged this pull request with Graphite.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here