test(blockifier): test negative flows of cairo1 revert trace

[dorimedini-starkware]

No description provided.

[dorimedini-starkware]

• feat(blockifier): keep revert error structure in TransactionExecutionInfo #1491
• feat(blockifier): cairo1 revert stack now part of ErrorStack #1490
• test(blockifier): test negative flows of cairo1 revert trace #1469 👈 (View in Graphite)
• feat(blockifier): limit characters in cairo1 revert trace #1468
• feat(blockifier): structured cairo1 stack trace #1461
• test(blockifier): add class hash (if set) to cairo1 revert trace #1460
• feat(blockifier): add address and selector for intermediate cairo1 revert errors #1459
• test(blockifier): named values in test #1458
• refactor(blockifier): format retdata in ExecutionFailed and PanicInValidate errors #1457
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[lotem-starkware]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.06%. Comparing base (e3165c4) to head (94c7206).
Report is 57 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1469       +/-   ##
===========================================
+ Coverage   40.10%   69.06%   +28.96%     
===========================================
  Files          26      100       +74     
  Lines        1895    13446    +11551     
  Branches     1895    13446    +11551     
===========================================
+ Hits          760     9287     +8527     
- Misses       1100     3759     +2659     
- Partials       35      400      +365     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[github-actions]

Artifacts upload triggered. View details here

[ilyalesokhin-starkware]

crates/blockifier/src/execution/stack_trace_test.rs line 1042 at r4 (raw file):

/// If extraction function is called with a successful callinfo, it should return an empty stack and
/// the original retdata.

This is strange.

Shouldn't it panic in that case?

Code quote:

/// If extraction function is called with a successful callinfo, it should return an empty stack and
/// the original retdata.

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware and @Yoni-Starkware)

---

crates/blockifier/src/execution/stack_trace_test.rs line 1042 at r4 (raw file):

Previously, ilyalesokhin-starkware wrote…

This is strange.

Shouldn't it panic in that case?

We don't want to panic at all in the stack extraction; if the input is "malformed" we use a fallback by design

[ilyalesokhin-starkware]

crates/blockifier/src/execution/stack_trace_test.rs line 1042 at r4 (raw file):

Previously, dorimedini-starkware wrote…

We don't want to panic at all in the stack extraction; if the input is "malformed" we use a fallback by design

We shouldn't call that function in that case.
I guess I'm ok with the current behavior but it is a bit strange to test it.

[ilyalesokhin-starkware]

crates/blockifier/src/execution/stack_trace_test.rs line 1042 at r4 (raw file):

Previously, ilyalesokhin-starkware wrote…

We shouldn't call that function in that case.
I guess I'm ok with the current behavior but it is a bit strange to test it.

can you just update the comment and say that we don't expect the function to be called in this case?

[github-actions]

Artifacts upload triggered. View details here

[ilyalesokhin-starkware]

Reviewed 1 of 1 files at r5.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @Yoni-Starkware)

[dorimedini-starkware]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)