test(blockifier): named values in test #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Oct 19, 2024
dorimedini-starkware
requested review from
ilyalesokhin-starkware and
Yoni-Starkware
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1458 +/- ##
==========================================
- Coverage 74.18% 70.20% -3.99%
==========================================
Files 359 95 -264
Lines 36240 13048 -23192
Branches 36240 13048 -23192
==========================================
- Hits 26886 9160 -17726
+ Misses 7220 3488 -3732
+ Partials 2134 400 -1734
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dorimedini-starkware
force-pushed
the
10-19-refactor_blockifier_format_retdata_in_executionfailed_and_panicinvalidate_errors
branch
from
b98800b to
8921342
Compare
dorimedini-starkware
force-pushed
the
10-19-test_blockifier_named_values_in_test
branch
from
3e385dd to
65fde15
Compare
Yoni-Starkware
approved these changes
Oct 20, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
dorimedini-starkware
changed the base branch from
10-19-refactor_blockifier_format_retdata_in_executionfailed_and_panicinvalidate_errors
to
graphite-base/1458
dorimedini-starkware
force-pushed
the
graphite-base/1458
branch
from
8921342 to
7f33e04
Compare
dorimedini-starkware
force-pushed
the
10-19-test_blockifier_named_values_in_test
branch
from
65fde15 to
1ec23a9
Compare
dorimedini-starkware
force-pushed
the
10-19-test_blockifier_named_values_in_test
branch
from
1ec23a9 to
9932c7b
Compare
|
|
This was referenced Oct 20, 2024
guy-starkware
pushed a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.