Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(blockifier): add class hash (if set) to cairo1 revert trace #1460

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@lotem-starkware
Copy link
Contributor

This change is Reviewable

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.23%. Comparing base (e3165c4) to head (147843a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1460       +/-   ##
===========================================
+ Coverage   40.10%   67.23%   +27.12%     
===========================================
  Files          26      102       +76     
  Lines        1895    13682    +11787     
  Branches     1895    13682    +11787     
===========================================
+ Hits          760     9199     +8439     
- Misses       1100     4082     +2982     
- Partials       35      401      +366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from bf939d7 to 16e16d5 Compare October 19, 2024 16:54
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from bc6318a to df2cd9d Compare October 19, 2024 16:54
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 16e16d5 to 6fd50ef Compare October 20, 2024 07:21
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from df2cd9d to c0a1bcc Compare October 20, 2024 07:22
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch 2 times, most recently from 9c095c5 to c033bb8 Compare October 20, 2024 07:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from c0a1bcc to 2f01bf1 Compare October 20, 2024 07:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from c033bb8 to d462d20 Compare October 20, 2024 09:22
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 2f01bf1 to 2976b8f Compare October 20, 2024 09:22
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from d462d20 to bb88184 Compare October 20, 2024 09:37
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 2976b8f to eb2ede4 Compare October 20, 2024 09:37
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from bb88184 to 06ddc79 Compare October 20, 2024 10:05
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from eb2ede4 to ae4ddcf Compare October 20, 2024 10:05
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 06ddc79 to 969f042 Compare October 20, 2024 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from ae4ddcf to 56b3ad1 Compare October 20, 2024 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 969f042 to 68e71d9 Compare October 20, 2024 15:02
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 2f2469f to 4258133 Compare October 21, 2024 09:43
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 36b4800 to 93a8b55 Compare October 21, 2024 10:44
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 4258133 to 5a72076 Compare October 21, 2024 10:44
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 93a8b55 to 5a99b36 Compare October 21, 2024 12:04
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 5a72076 to 2c3ce39 Compare October 21, 2024 12:04
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 5a99b36 to 2bdcbac Compare October 21, 2024 15:43
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 2c3ce39 to 4ff4199 Compare October 21, 2024 15:43
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 2bdcbac to 4ff75dd Compare October 21, 2024 18:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 4ff4199 to aa3485b Compare October 21, 2024 18:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 4ff75dd to dcc2473 Compare October 21, 2024 19:20
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from aa3485b to b720ffa Compare October 21, 2024 19:20
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from dcc2473 to a3a67e6 Compare October 22, 2024 08:40
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from b720ffa to 5e0478c Compare October 22, 2024 08:40
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from a3a67e6 to 4d89d8c Compare October 22, 2024 08:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 5e0478c to d70ede1 Compare October 22, 2024 08:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 4d89d8c to 50e14cd Compare October 22, 2024 09:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from d70ede1 to 2881004 Compare October 22, 2024 09:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 50e14cd to 6494b11 Compare October 22, 2024 09:31
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 2881004 to 6d58105 Compare October 22, 2024 09:31
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors branch from 6494b11 to 251c7e1 Compare October 22, 2024 11:51
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 6d58105 to 84e46f4 Compare October 22, 2024 11:51
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-19-feat_blockifier_add_address_and_selector_for_intermediate_cairo1_revert_errors to graphite-base/1460 October 22, 2024 12:54
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from 84e46f4 to bfa7ce4 Compare October 22, 2024 12:54
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/1460 to main October 22, 2024 12:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-19-test_blockifier_add_class_hash_if_set_to_cairo1_revert_trace branch from bfa7ce4 to 147843a Compare October 22, 2024 12:55
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware merged commit e4d316b into main Oct 22, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants