Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make the patricia_key and class_hash macros self contained #1465

Merged
merged 1 commit into from
Oct 27, 2024
Merged

chore: make the patricia_key and class_hash macros self contained #1465

merged 1 commit into from
Oct 27, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@ArniStarkware ArniStarkware mentioned this pull request Oct 20, 2024
Closed
@ArniStarkware Graphite App
Copy link
Contributor Author

ArniStarkware commented Oct 20, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

This was referenced Oct 20, 2024
Merged
Merged
@lotem-starkware
Copy link
Contributor

This change is Reviewable

@ArniStarkware ArniStarkware mentioned this pull request Oct 20, 2024
Closed
@ArniStarkware ArniStarkware marked this pull request as ready for review October 20, 2024 05:13
@github-actions GitHub Actions
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [29.931 ms 29.980 ms 30.036 ms]
change: [-3.2181% -2.0722% -1.0682%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) high mild
2 (2.00%) high severe

@codecov Codecov
Copy link

codecov bot commented Oct 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.50%. Comparing base (e3165c4) to head (023cf22).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1465       +/-   ##
===========================================
+ Coverage   40.10%   64.50%   +24.39%     
===========================================
  Files          26      217      +191     
  Lines        1895    25293    +23398     
  Branches     1895    25293    +23398     
===========================================
+ Hits          760    16315    +15555     
- Misses       1100     7692     +6592     
- Partials       35     1286     +1251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from 9e7e9a5 to 64818a3 Compare October 20, 2024 07:26
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/patricia_key branch from a4cd793 to 310adde Compare October 20, 2024 07:26
@elintul elintul removed their request for review October 20, 2024 13:48
MohammadNassar1
MohammadNassar1 approved these changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from 64818a3 to f3ce6d4 Compare October 21, 2024 06:18
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/patricia_key branch from 310adde to 02ca477 Compare October 21, 2024 06:18
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from f3ce6d4 to ad2a114 Compare October 21, 2024 06:55
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/patricia_key branch from 02ca477 to 2c21ba4 Compare October 21, 2024 06:55
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch 2 times, most recently from 630a50a to b394585 Compare October 21, 2024 08:02
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/patricia_key branch from 2c21ba4 to b11a15b Compare October 21, 2024 08:02
@github-actions GitHub Actions
Copy link

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.214 ms 30.260 ms 30.307 ms]
change: [-21.666% -14.979% -8.3105%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/retdata branch from b394585 to 1e2fe53 Compare October 21, 2024 16:15
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/patricia_key branch 2 times, most recently from 3ee6938 to 2582986 Compare October 22, 2024 06:55
@ArniStarkware ArniStarkware changed the base branch from arni/self_contained_macros/retdata to graphite-base/1465 October 23, 2024 07:08
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/patricia_key branch from 2582986 to b1a5858 Compare October 23, 2024 07:08
@ArniStarkware ArniStarkware changed the base branch from graphite-base/1465 to main October 23, 2024 07:09
@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/patricia_key branch from b1a5858 to d1e2ba6 Compare October 23, 2024 07:09
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/patricia_key branch from d1e2ba6 to 0ccf6f3 Compare October 23, 2024 07:11
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/patricia_key branch from 0ccf6f3 to 023cf22 Compare October 25, 2024 08:04
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.933 ms 36.437 ms 37.017 ms]
change: [+2.5489% +3.9349% +5.7098%] (p = 0.00 < 0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) high mild
9 (9.00%) high severe

MohammadNassar1
MohammadNassar1 approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@ArniStarkware ArniStarkware merged commit 9036e0a into main Oct 27, 2024
22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2024
@ArniStarkware ArniStarkware deleted the arni/self_contained_macros/patricia_key branch November 28, 2024 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MohammadNassar1 MohammadNassar1 MohammadNassar1 approved these changes

@dorimedini-starkware dorimedini-starkware Awaiting requested review from dorimedini-starkware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArniStarkware @lotem-starkware @MohammadNassar1