chore: split transaction file part one fields dedicated file

[ArniStarkware]

This change is 

[ArniStarkware]

• chore: split transaction file part one fields dedicated file #1219 👈
• chore: make the patricia_key and class_hash macros self contained #1465
• chore: refactor retdata macro to not require import of the type #1464
• chore: make calldata macro self contained #1463
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 68.75000% with 65 lines in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (b0cfe82) to head (9df9c1b).
Report is 335 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/starknet_api/src/transaction/fields.rs	69.15%	48 Missing and 14 partials ⚠️
crates/native_blockifier/src/py_transaction.rs	0.00%	2 Missing ⚠️
crates/papyrus_rpc/src/v0_8/transaction.rs	80.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (9df9c1b). Click for more details.

HEAD has 2 uploads less than BASE

Flag	BASE (b0cfe82)	HEAD (9df9c1b)
	3	1

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1219       +/-   ##
===========================================
- Coverage   74.18%   63.78%   -10.41%     
===========================================
  Files         359      345       -14     
  Lines       36240    37177      +937     
  Branches    36240    37177      +937     
===========================================
- Hits        26886    23713     -3173     
- Misses       7220    11507     +4287     
+ Partials     2134     1957      -177     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ArniStarkware]

The file transaction.rs is over 1000 lines long and holds more than transactions. As a first step, let us split the fields into a dedicated file.

Reviewable status: 0 of 4 files reviewed, 4 unresolved discussions

---

crates/blockifier/src/transaction/objects.rs line 11 at r1 (raw file):

    AccountDeploymentData,
    AllResourceBounds,
    Fee,

Remove this file from the PR.

Code quote:

use std::collections::HashMap;

use cairo_vm::types::builtin_name::BuiltinName;
use cairo_vm::vm::runners::cairo_runner::ExecutionResources;
use starknet_api::core::{ContractAddress, Nonce};
use starknet_api::data_availability::DataAvailabilityMode;
use starknet_api::transaction::fields::signed_tx_version;
use starknet_api::transaction::{
    AccountDeploymentData,
    AllResourceBounds,
    Fee,

---

crates/starknet_api/src/transaction.rs line 19 at r1 (raw file):

// TODO(Arni): Remove the use of pub use.
pub use crate::transaction::fields::{
    AccountDeploymentData,

add

Suggestion:

    signed_tx_version, signed_tx_version_from_tx, AccountDeploymentData,

---

crates/starknet_api/src/transaction.rs line 52 at r1 (raw file):

// TODO(Arni): Remove the use of pub use.
pub mod fields;
pub use crate::transaction::fields::{TransactionOptions, QUERY_VERSION_BASE_BIT};

Squash into the other pub use.

Code quote:

// TODO(Arni): Remove the use of pub use.
pub mod fields;
pub use crate::transaction::fields::{TransactionOptions, QUERY_VERSION_BASE_BIT};

---

crates/starknet_api/src/transaction_hash.rs line 13 at r1 (raw file):

    DeclareTransaction,
    DeclareTransactionV0V1,
    DeclareTransactionV2,

remove this file from the PR.

Code quote:

use std::sync::LazyLock;

use starknet_types_core::felt::Felt;

use crate::block::BlockNumber;
use crate::core::{ascii_as_felt, calculate_contract_address, ChainId, ContractAddress};
use crate::crypto::utils::HashChain;
use crate::data_availability::DataAvailabilityMode;
use crate::transaction::fields::signed_tx_version_from_tx;
use crate::transaction::{
    DeclareTransaction,
    DeclareTransactionV0V1,
    DeclareTransactionV2,

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [35.354 ms 35.409 ms 35.467 ms]
change: [-6.0921% -4.0680% -2.2144%] (p = 0.00 < 0.05)
Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) high mild