-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor retdata macro to not require import of the type #1464
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1464 +/- ##
===========================================
- Coverage 74.18% 58.46% -15.73%
===========================================
Files 359 143 -216
Lines 36240 17954 -18286
Branches 36240 17954 -18286
===========================================
- Hits 26886 10497 -16389
+ Misses 7220 6751 -469
+ Partials 2134 706 -1428
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5d84954
to
113ef96
Compare
9e7e9a5
to
64818a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dorimedini-starkware)
a discussion (no related file):
Why it's not over main
branch?
Previously, MohammadNassar1 (mohammad-starkware) wrote…
To avoid conflicts with myself. |
113ef96
to
ab8bd98
Compare
64818a3
to
f3ce6d4
Compare
ab8bd98
to
2ec9fc6
Compare
f3ce6d4
to
ad2a114
Compare
ad2a114
to
630a50a
Compare
2ec9fc6
to
64f4db5
Compare
630a50a
to
b394585
Compare
b394585
to
1e2fe53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
No description provided.