Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make calldata macro self contained #1463

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@lotem-starkware
Copy link
Contributor

This change is Reviewable

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.11%. Comparing base (b0cfe82) to head (2ec9fc6).
Report is 447 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (b0cfe82) and HEAD (2ec9fc6). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b0cfe82) HEAD (2ec9fc6)
3 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   74.18%   68.11%   -6.08%     
==========================================
  Files         359      176     -183     
  Lines       36240    23251   -12989     
  Branches    36240    23251   -12989     
==========================================
- Hits        26886    15837   -11049     
+ Misses       7220     6160    -1060     
+ Partials     2134     1254     -880     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/calldata branch from 5d84954 to 113ef96 Compare October 20, 2024 07:26
@ArniStarkware ArniStarkware changed the base branch from arni/self_contained_macros/fix_check_macros_imports to main October 20, 2024 07:26
@elintul elintul removed their request for review October 20, 2024 13:46
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/calldata branch from 113ef96 to ab8bd98 Compare October 21, 2024 06:18
Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@ArniStarkware ArniStarkware force-pushed the arni/self_contained_macros/calldata branch from ab8bd98 to 2ec9fc6 Compare October 21, 2024 06:55
Copy link

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [35.038 ms 35.487 ms 36.042 ms]
change: [-4.6399% -2.8509% -1.0882%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) high severe

Copy link
Contributor

@MohammadNassar1 MohammadNassar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@ArniStarkware ArniStarkware merged commit 64f4db5 into main Oct 21, 2024
21 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 22, 2024
@ArniStarkware ArniStarkware deleted the arni/self_contained_macros/calldata branch October 26, 2024 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants