feat: implementing ComponentRunner for the gateway

[lev-starkware]

Stack:

• refactor: refactor integration tests to use mempool_node modules #339
• feat: feat: adding main module #311
• feat: implementing ComponentRunner for the gateway #355 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.85%. Comparing base (a2b8df2) to head (37d7bc8).

Files	Patch %	Lines
crates/gateway/src/gateway.rs	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   80.80%   80.85%   +0.04%     
==========================================
  Files          35       35              
  Lines        1620     1619       -1     
  Branches     1620     1619       -1     
==========================================
  Hits         1309     1309              
+ Misses        245      244       -1     
  Partials       66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Itay-Tsabary-Starkware]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware and @dafnamatsry)

[ArniStarkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @lev-starkware)

---

crates/gateway/src/gateway.rs line 74 at r1 (raw file):

            .route("/is_alive", get(is_alive))
            .route("/add_tx", post(add_tx))
            .with_state(self.app_state.clone())

I am unsure if a clone is the intended behavior.

Maybe we should fix app_state so that it would implement Copy (or whatever the issue is). (Make all the members hide behind Arc).

This is not a big deal for now, but maybe it will be in the future.

Code quote:

self.app_state.clone()

---

crates/gateway/src/gateway.rs line 148 at r1 (raw file):

#[async_trait]
impl ComponentRunner for Gateway {
    async fn start(&mut self) -> Result<(), ComponentStartError> {

A question about Rust / design (probably out of scope for this PR).

Does the fact that start gets a reference to mut self means a single ComponentRunner may run many instances of the component?

Code quote:

impl ComponentRunner for Gateway {
    async fn start(&mut self) -> Result<(), ComponentStartError> {

[ArniStarkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @lev-starkware)

---

crates/gateway/src/gateway.rs line 74 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

I am unsure if a clone is the intended behavior.

Maybe we should fix app_state so that it would implement Copy (or whatever the issue is). (Make all the members hide behind Arc).

This is not a big deal for now, but maybe it will be in the future.

If you think it is an issue, add a to-do (for someone on my team, say myself) to fix it.

[ArniStarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

---

crates/gateway/src/gateway.rs line 74 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

If you think it is an issue, add a to-do (for someone on my team, say myself) to fix it.

from F2f. Please add a todo on my name.

---

crates/gateway/src/gateway.rs line 148 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

A question about Rust / design (probably out of scope for this PR).

Does the fact that start gets a reference to mut self means a single ComponentRunner may run many instances of the component?

From F2F:

The important thing here is the mut, not the ref (&).
It is only logical that a runner would like to mutate itself.

[ArniStarkware]

Reviewed 1 of 2 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)

[dafnamatsry]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lev-starkware)

---

crates/gateway/src/gateway.rs line 74 at r1 (raw file):

            .route("/is_alive", get(is_alive))
            .route("/add_tx", post(add_tx))
            .with_state(self.app_state.clone())

I think dereferencing should work here.

Suggestion:

*self.app_state

[ArniStarkware]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware and @lev-starkware)

[lev-starkware]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @dafnamatsry and @Itay-Tsabary-Starkware)

---

crates/gateway/src/gateway.rs line 74 at r1 (raw file):

Previously, dafnamatsry wrote…

I think dereferencing should work here.

I tried it not compiling.

[Itay-Tsabary-Starkware]

Dismissed @dafnamatsry from a discussion.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)

[Itay-Tsabary-Starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @dafnamatsry)

[Itay-Tsabary-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[lev-starkware]

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

By permission of dafna.

[lev-starkware]

✓ Commit merged in pull request #339