fix: change ComponentRunner start param to '&mut self'

commit-id:6ec10946
starkware-libs · Jun 26, 2024 · bb0e379 · bb0e379
1 parent 1ba1c91
commit bb0e379
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/crates/mempool_infra/src/component_runner.rs b/crates/mempool_infra/src/component_runner.rs
@@ -22,5 +22,5 @@ pub trait ComponentCreator<T: SerializeConfig> {
 #[async_trait]
 pub trait ComponentRunner {
     /// Start the component. Normally this function should never return.
-    async fn start(&self) -> Result<(), ComponentStartError>;
+    async fn start(&mut self) -> Result<(), ComponentStartError>;
 }
diff --git a/crates/mempool_infra/src/component_runner_test.rs b/crates/mempool_infra/src/component_runner_test.rs
@@ -48,7 +48,7 @@ mod test_component_a {
 
     #[async_trait]
     impl ComponentRunner for TestComponentA {
-        async fn start(&self) -> Result<(), ComponentStartError> {
+        async fn start(&mut self) -> Result<(), ComponentStartError> {
             println!("TestComponent1::start(), component: {:#?}", self);
             self.local_start().await.map_err(|_err| ComponentStartError::InternalComponentError)
         }
@@ -87,7 +87,7 @@ mod test_component_b {
 
     #[async_trait]
     impl ComponentRunner for TestComponentB {
-        async fn start(&self) -> Result<(), ComponentStartError> {
+        async fn start(&mut self) -> Result<(), ComponentStartError> {
             println!("TestComponent2::start(): component: {:#?}", self);
             match self.config.u32_field {
                 43 => Err(ComponentStartError::InternalComponentError),
@@ -103,7 +103,7 @@ use test_component_a::{TestComponentA, TestConfigA};
 #[tokio::test]
 async fn test_component_a() {
     let test_config = TestConfigA { bool_field: true };
-    let component = TestComponentA::create(test_config);
+    let mut component = TestComponentA::create(test_config);
     assert_matches!(component.start().await, Ok(()));
 }
 
@@ -112,17 +112,17 @@ use test_component_b::{TestComponentB, TestConfigB};
 #[tokio::test]
 async fn test_component_b() {
     let test_config = TestConfigB { u32_field: 42 };
-    let component = TestComponentB::create(test_config);
+    let mut component = TestComponentB::create(test_config);
     assert_matches!(component.start().await, Ok(()));
 
     let test_config = TestConfigB { u32_field: 43 };
-    let component = TestComponentB::create(test_config);
+    let mut component = TestComponentB::create(test_config);
     assert_matches!(component.start().await, Err(e) => {
         assert_eq!(e, ComponentStartError::InternalComponentError);
     });
 
     let test_config = TestConfigB { u32_field: 44 };
-    let component = TestComponentB::create(test_config);
+    let mut component = TestComponentB::create(test_config);
     assert_matches!(component.start().await, Err(e) => {
         assert_eq!(e, ComponentStartError::ComponentConfigError);
     });