Added unwraps as const fns.
#6983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2025
|
This change is |
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
03a9ffa to
7ce12a6
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
4054872 to
602c81e
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
602c81e to
274a96c
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
2 times, most recently
from
379ba79 to
e15e888
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
274a96c to
90bb6fc
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
e15e888 to
9aa0f77
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
90bb6fc to
798c008
Compare
This was referenced Jan 5, 2025
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
9aa0f77 to
c40675a
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
798c008 to
57004ac
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
2 times, most recently
from
ced3c81 to
907bbe6
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
577b5d8 to
d72ca5a
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
907bbe6 to
0a85e5c
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
d72ca5a to
f9d1d45
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
0a85e5c to
0e4f43f
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
f9d1d45 to
cf077b8
Compare
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
0e4f43f to
8497b09
Compare
commit-id:7148ebf6
orizi
force-pushed
the
spr/main/7148ebf6
branch
from
8497b09 to
055d3ef
Compare
TomerStarkware
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
powin constant eval. #6996div_rem. #6995!for const evaluation. #6994==!=<<=>and>=in const eval. #6993unwraps as const fns. #6983 ⬅