Refactored const evaluation by usage of context. #6977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2025
|
This change is |
This was referenced Jan 4, 2025
orizi
force-pushed
the
spr/main/5bb86a4b
branch
from
2b99226 to
eff3a1f
Compare
orizi
force-pushed
the
spr/main/9949a206
branch
from
8ee1dc9 to
b585e87
Compare
orizi
force-pushed
the
spr/main/5bb86a4b
branch
from
eff3a1f to
e631acc
Compare
orizi
force-pushed
the
spr/main/9949a206
branch
2 times, most recently
from
7549d9f to
65fcc0f
Compare
orizi
force-pushed
the
spr/main/5bb86a4b
branch
from
e631acc to
0d6ff46
Compare
This additionally reduced some duplicated diagnostics clutter. commit-id:5bb86a4b
orizi
force-pushed
the
spr/main/5bb86a4b
branch
from
0d6ff46 to
044019d
Compare
TomerStarkware
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
This was referenced Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additionally reduced some duplicated diagnostics clutter.
Stack:
powin constant eval. #6996div_rem. #6995!for const evaluation. #6994==!=<<=>and>=in const eval. #6993unwraps as const fns. #6983