Refactored constant constant fetches. #6980
Merged
+85
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2025
|
This change is |
orizi
force-pushed
the
spr/main/32414893
branch
from
ff5b766 to
510c95c
Compare
orizi
force-pushed
the
spr/main/d9744772
branch
from
2a3687b to
1895b69
Compare
orizi
force-pushed
the
spr/main/d9744772
branch
from
1895b69 to
6467d2f
Compare
orizi
force-pushed
the
spr/main/32414893
branch
from
510c95c to
bca0dc1
Compare
orizi
force-pushed
the
spr/main/d9744772
branch
from
6467d2f to
d8c63d2
Compare
orizi
force-pushed
the
spr/main/32414893
branch
from
bca0dc1 to
6bb0dac
Compare
orizi
force-pushed
the
spr/main/d9744772
branch
from
d8c63d2 to
53b8220
Compare
orizi
force-pushed
the
spr/main/32414893
branch
from
6bb0dac to
97fdfd3
Compare
TomerStarkware
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
This was referenced Jan 5, 2025
orizi
force-pushed
the
spr/main/d9744772
branch
from
53b8220 to
ff39e33
Compare
orizi
force-pushed
the
spr/main/32414893
branch
2 times, most recently
from
8f6294b to
4fbb253
Compare
orizi
force-pushed
the
spr/main/d9744772
branch
from
ff39e33 to
fabac0a
Compare
orizi
force-pushed
the
spr/main/32414893
branch
from
4fbb253 to
b51d18e
Compare
orizi
force-pushed
the
spr/main/d9744772
branch
from
fabac0a to
9371bca
Compare
commit-id:32414893
orizi
force-pushed
the
spr/main/32414893
branch
from
b51d18e to
b5ea287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
powin constant eval. #6996div_rem. #6995!for const evaluation. #6994==!=<<=>and>=in const eval. #6993unwraps as const fns. #6983