Added evaluation of const fns. #6982
Merged
+127
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 4, 2025
|
This change is |
orizi
force-pushed
the
spr/main/4682d984
branch
from
4054872 to
602c81e
Compare
orizi
force-pushed
the
spr/main/3405e803
branch
from
08e3b19 to
12950cb
Compare
orizi
force-pushed
the
spr/main/3405e803
branch
from
12950cb to
4a7f9f0
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
602c81e to
274a96c
Compare
orizi
force-pushed
the
spr/main/3405e803
branch
from
4a7f9f0 to
40e48dd
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
274a96c to
90bb6fc
Compare
orizi
force-pushed
the
spr/main/3405e803
branch
from
40e48dd to
90e8dbf
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
90bb6fc to
798c008
Compare
This was referenced Jan 5, 2025
orizi
force-pushed
the
spr/main/4682d984
branch
from
798c008 to
57004ac
Compare
orizi
force-pushed
the
spr/main/3405e803
branch
from
90e8dbf to
1895749
Compare
TomerStarkware
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
TomerStarkware
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Reviewable status:
orizi
force-pushed
the
spr/main/4682d984
branch
from
57004ac to
04b8e01
Compare
orizi
force-pushed
the
spr/main/3405e803
branch
from
3025f6b to
6ea12f2
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
2 times, most recently
from
577b5d8 to
d72ca5a
Compare
orizi
force-pushed
the
spr/main/3405e803
branch
from
6ea12f2 to
f3981e7
Compare
orizi
force-pushed
the
spr/main/4682d984
branch
from
d72ca5a to
f9d1d45
Compare
orizi
force-pushed
the
spr/main/3405e803
branch
from
f3981e7 to
ef1b36b
Compare
commit-id:4682d984
orizi
force-pushed
the
spr/main/4682d984
branch
from
f9d1d45 to
cf077b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
powin constant eval. #6996div_rem. #6995!for const evaluation. #6994==!=<<=>and>=in const eval. #6993unwraps as const fns. #6983