-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GPU based transfer to do chroma conversions of native decoder output #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🎞️ video
labels
Oct 10, 2024
Wumpf
force-pushed
the
andreas/av1-chroma-upsampling-gpu2
branch
from
October 11, 2024 10:36
84ae3ba
to
df56fe4
Compare
emilk
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome-sauce!
Comment on lines
+213
to
+219
dav1d::pixel::YUVRange::Limited => YuvRange::Limited, | ||
dav1d::pixel::YUVRange::Full => YuvRange::Full, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Wumpf
force-pushed
the
andreas/av1-chroma-upsampling-gpu2
branch
from
October 11, 2024 14:52
ae423ad
to
5f872b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
rav1d/dav1d
#7605Fixes performance issues with our previous inefficient cpu based chroma conversion:
... and fixes color space issues:
Top left: now
Top right: before
Bottom: VLC
There was an oversight in the conversion pipeline that if fixed now: It only allowed for creating new textures.
Now it can also update existing textures! This means that it takes a target texture from the outside. Naturally, there's some constraints on what the target texture looks like and as a consequence I added some validation for that. Could be more, but I think this is solid enough for our purposes :)
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.