clean up todos and '…' usage

rerun-io · Oct 11, 2024 · ae423ad · ae423ad
1 parent df56fe4
commit ae423ad
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 23 deletions.
diff --git a/crates/store/re_video/Cargo.toml b/crates/store/re_video/Cargo.toml
@@ -32,8 +32,8 @@ av1 = ["dep:dav1d"]
 ## Enable faster native video decoding with assembly.
 ## You need to install [nasm](https://nasm.us/) to compile with this feature.
 # TODO(#7671): this feature flag currently does nothing
-# nasm = ["dav1d?/default"] # The default feature set of dav1d has asm enabled
-nasm = [] ## TODO(#7671): fix Linux build
+nasm = ["dav1d?/default"] # The default feature set of dav1d has asm enabled
+#nasm = [] ## TODO(#7671): fix Linux build
 
 [dependencies]
 re_log.workspace = true

diff --git a/crates/store/re_video/src/decode/av1.rs b/crates/store/re_video/src/decode/av1.rs
@@ -249,7 +249,7 @@ fn color_primaries(picture: &dav1d::Picture) -> ColorPrimaries {
                 //     ColorPrimaries::Bt601
                 // }
                 //
-                // ... then again, eyeballing VLC it looks like it just always assumes BT.709.
+                // …then again, eyeballing VLC it looks like it just always assumes BT.709.
                 // The handwavy test case employed here was the same video in low & high resolution
                 // without specified primaries. Both looked the same.
                 ColorPrimaries::Bt709

diff --git a/crates/viewer/re_renderer/src/resource_managers/yuv_converter.rs b/crates/viewer/re_renderer/src/resource_managers/yuv_converter.rs
@@ -300,26 +300,6 @@ impl YuvFormatConversionTask {
         input_data: &GpuTexture,
         target_texture: &GpuTexture,
     ) -> Self {
-        // TODO:
-        // let target_texture = ctx.gpu_resources.textures.alloc(
-        //     &ctx.device,
-        //     &TextureDesc {
-        //         label: output_label.clone(),
-        //         size: wgpu::Extent3d {
-        //             width: output_width_height[0],
-        //             height: output_width_height[1],
-        //             depth_or_array_layers: 1,
-        //         },
-        //         mip_level_count: 1, // We don't have mipmap level generation yet!
-        //         sample_count: 1,
-        //         dimension: wgpu::TextureDimension::D2,
-        //         format: Self::OUTPUT_FORMAT,
-        //         usage: output_usage_flags | wgpu::TextureUsages::RENDER_ATTACHMENT,
-        //     },
-        // );
-
-        // TODO: validate target_texture
-
         let target_label = target_texture.creation_desc.label.clone();
         let renderer = ctx.renderer::<YuvFormatConverter>();