Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use GPU based transfer to do chroma conversions of native decoder out…
…put (#7682) ### What * Important chunk of #7605 * Related to #7608 * todo: create a new ticket for bgr shenanigans and close this one --- Fixes performance issues with our previous inefficient cpu based chroma conversion: ![image](https://github.com/user-attachments/assets/fed67eb9-902b-43d8-bbd6-8574a5f3b18d) ... and fixes color space issues: Top left: now Top right: before Bottom: VLC ![image](https://github.com/user-attachments/assets/f5b797bd-e12d-46b0-96dd-32176d43e78c) --- There was an oversight in the conversion pipeline that if fixed now: It only allowed for creating new textures. Now it can also update existing textures! This means that it takes a target texture from the outside. Naturally, there's some constraints on what the target texture looks like and as a consequence I added some validation for that. Could be more, but I think this is solid enough for our purposes :) ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7682?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7682?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7682) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
- Loading branch information