Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GPU based transfer to do chroma conversions of native decoder output #7682

Merged
merged 13 commits into from
Oct 11, 2024
Merged

Use GPU based transfer to do chroma conversions of native decoder output #7682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cbf55d5
transfer_image_data_to_texture can now update existing textures
Wumpf Oct 10, 2024
4673d8f
wire up native_decoder to transfer_image_data_to_texture
Wumpf Oct 9, 2024
3c8bd6b
handle strides in YUV data
Wumpf Oct 10, 2024
0881d5c
add profiling scopes for slow yuv plane copy paths
Wumpf Oct 11, 2024
c5afa8c
improve av1 fast path further
Wumpf Oct 11, 2024
06b0515
clean up todos and '…' usage
Wumpf Oct 11, 2024
c8bb8c2
pass through debug name to `output_picture`
Wumpf Oct 11, 2024
fb18389
even more debug name!
Wumpf Oct 11, 2024
f489be8
more explicit unreachableness of Rgb8unorm later down in copy_video_f…
Wumpf Oct 11, 2024
5f872b3
not break almost _everything_ else
Wumpf Oct 11, 2024
4e201d1
fix re_video example
Wumpf Oct 11, 2024
5740e2f
fix oversight on trying to make conditions easier to read, caused pad…
Wumpf Oct 11, 2024
6294334
add a comment pointing to how common it is to change colors depending on
Wumpf Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/store/re_video/examples/frames.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,16 @@ fn main() {
video.config.coded_height
);

let mut decoder = create_decoder(&video);
let mut decoder = create_decoder(video_path, &video);

write_video_frames(&video, decoder.as_mut(), &output_dir);
}

fn create_decoder(video: &VideoData) -> Box<dyn SyncDecoder> {
fn create_decoder(debug_name: &str, video: &VideoData) -> Box<dyn SyncDecoder> {
if video.config.is_av1() {
Box::new(
re_video::decode::av1::SyncDav1dDecoder::new().expect("Failed to start AV1 decoder"),
re_video::decode::av1::SyncDav1dDecoder::new(debug_name.to_owned())
.expect("Failed to start AV1 decoder"),
)
} else {
panic!("Unsupported codec: {}", video.human_readable_codec_string());
Expand Down
Loading
Loading