🎉 (entity selector) sort by name or value

[sophiamersmann]

Cycle 2024.2: Entity selector | Designs

Summary

Adds a dropdown menu to sort by name or indicator, as well as a button to toggle the sort order. Draws a simple bar chart when sorted by an indicator.

Details

• Indicators considered for sorting are all indicators of the chart that can be formatted numerically (includes NumberOrStringColumn) and that are not projections
• Names are sorted asc by default, while numerical values are sorted desc by default
• If sorted by an indicator, then values without data are listed at the end (and are marked with a "No data" label)

Caveats

• The (display) name of a column that is used as dropdown option is not always nice :( (but we surface it in other places already..)
• We can't draw a bar chart for negative values. For now, we opted to simply not draw anything in that case

SVG tester

The SVG tester fails due to the changes in #3373

Data

• Go through the top 50 charts and make sure all columns have appropriate display names

[sophiamersmann]

• 🎉 (entity selector) sort by external indicators #3466 : 2 dependent PRs (#3443 , #3490 )
• 🎉 (entity selector) highlight user location #3452
• 🎉 (entity selector) sort by name or value #3447 👈
• ✨ (entity selector) redesign #3436
• 🔨 (grapher) refactor modals #3435
• 🔨 (grapher) add CloseButton component #3434
• ✨ (entity selector) render into panel, drawer or modal #3373
• ✨ (entity selector) remove slide-in settings drawer #3353 : 2 other dependent PRs (#3356 , #3363 )
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

[marcelgerber]

Nice work! Sorry for finding the performance issue there, will try to look into it 👀

[sophiamersmann]

Merge activity

• May 3, 4:04 AM EDT: @sophiamersmann started a stack merge that includes this pull request via Graphite.
• May 3, 4:14 AM EDT: Graphite rebased this pull request as part of a merge.
• May 3, 4:15 AM EDT: @sophiamersmann merged this pull request with Graphite.