-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 (entity selector) highlight user location #3452
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 5, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite |
This was referenced Apr 5, 2024
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 8, 2024 10:08
7ea0597
to
582c251
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 8, 2024 10:08
a22e00f
to
0891373
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 8, 2024 12:55
582c251
to
10e38bd
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 8, 2024 12:55
0891373
to
1d202e7
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 8, 2024 14:35
10e38bd
to
66ccba4
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 8, 2024 14:35
1d202e7
to
fc7383a
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 9, 2024 08:12
66ccba4
to
457a813
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 9, 2024 08:12
fc7383a
to
10d6d2e
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 9, 2024 13:52
457a813
to
3d8f2c6
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 9, 2024 13:52
10d6d2e
to
2d7cd5a
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 9, 2024 14:24
3d8f2c6
to
f731a1b
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 9, 2024 14:24
2d7cd5a
to
72512ae
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 9, 2024 14:28
f731a1b
to
231540c
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 9, 2024 14:28
72512ae
to
115bb3b
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 10, 2024 10:53
231540c
to
74553b7
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 10, 2024 10:53
115bb3b
to
e779013
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 10, 2024 16:06
74553b7
to
95124cb
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 10, 2024 16:06
e779013
to
265c819
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 11, 2024 12:50
3200095
to
08c4e60
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 11, 2024 12:50
f546933
to
88f4703
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 11, 2024 13:25
08c4e60
to
36fdb41
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 11, 2024 13:26
88f4703
to
34799bd
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 15, 2024 08:20
36fdb41
to
fb43bf0
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 15, 2024 08:20
34799bd
to
c4170b8
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 15, 2024 12:20
fb43bf0
to
32ad25a
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 15, 2024 12:20
c4170b8
to
e956f8d
Compare
marcelgerber
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
This was referenced Apr 16, 2024
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 17, 2024 10:35
32ad25a
to
323cd36
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
2 times, most recently
from
April 18, 2024 08:09
9bb9dc9
to
b719487
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 26, 2024 12:23
323cd36
to
5a63701
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 26, 2024 12:23
b719487
to
8d26977
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
April 26, 2024 17:03
5a63701
to
990e64c
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
April 26, 2024 17:03
8d26977
to
797f3fd
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
May 1, 2024 13:06
990e64c
to
222fc17
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
May 1, 2024 13:06
797f3fd
to
0829e33
Compare
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
May 2, 2024 14:03
222fc17
to
406c6f9
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
May 2, 2024 14:03
0829e33
to
94b6a61
Compare
Merge activity
|
sophiamersmann
force-pushed
the
entity-selector-sort
branch
from
May 3, 2024 08:13
406c6f9
to
6e78f59
Compare
sophiamersmann
force-pushed
the
entity-selector-location
branch
from
May 3, 2024 08:15
94b6a61
to
a56d68f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cycle 2024.2: Entity selector | Designs
Summary
Detects the user's location and displays it at the top of the list. Also shows a little icon next to the user's country/region with a tooltip rendered on hover.
Details
SVG tester
The SVG tester fails due to the changes in #3373