Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 (entity selector) highlight user location #3452

Merged
merged 1 commit into from
May 3, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Apr 5, 2024

Cycle 2024.2: Entity selector | Designs

Summary

Detects the user's location and displays it at the top of the list. Also shows a little icon next to the user's country/region with a tooltip rendered on hover.

Details

  • The user's location is displayed at the top if it's not currently selected (if it's already selected, then I don't think there is a need to move it to the top)

SVG tester

The SVG tester fails due to the changes in #3373

@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from a22e00f to 0891373 Compare April 8, 2024 10:08
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 0891373 to 1d202e7 Compare April 8, 2024 12:55
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 1d202e7 to fc7383a Compare April 8, 2024 14:35
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from fc7383a to 10d6d2e Compare April 9, 2024 08:12
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 10d6d2e to 2d7cd5a Compare April 9, 2024 13:52
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 2d7cd5a to 72512ae Compare April 9, 2024 14:24
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 72512ae to 115bb3b Compare April 9, 2024 14:28
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 115bb3b to e779013 Compare April 10, 2024 10:53
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from e779013 to 265c819 Compare April 10, 2024 16:06
Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch 2 times, most recently from 9bb9dc9 to b719487 Compare April 18, 2024 08:09
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from b719487 to 8d26977 Compare April 26, 2024 12:23
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 8d26977 to 797f3fd Compare April 26, 2024 17:03
@sophiamersmann sophiamersmann force-pushed the entity-selector-sort branch from 990e64c to 222fc17 Compare May 1, 2024 13:06
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 797f3fd to 0829e33 Compare May 1, 2024 13:06
@sophiamersmann sophiamersmann force-pushed the entity-selector-sort branch from 222fc17 to 406c6f9 Compare May 2, 2024 14:03
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 0829e33 to 94b6a61 Compare May 2, 2024 14:03
Copy link
Member Author

sophiamersmann commented May 3, 2024

Merge activity

@sophiamersmann sophiamersmann force-pushed the entity-selector-sort branch from 406c6f9 to 6e78f59 Compare May 3, 2024 08:13
Base automatically changed from entity-selector-sort to master May 3, 2024 08:15
@sophiamersmann sophiamersmann force-pushed the entity-selector-location branch from 94b6a61 to a56d68f Compare May 3, 2024 08:15
@sophiamersmann sophiamersmann merged commit a6e32bf into master May 3, 2024
11 of 17 checks passed
@sophiamersmann sophiamersmann deleted the entity-selector-location branch May 3, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants