perf(table): optimize tableForSelection calls
#3486
Merged
+54
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelgerber
force-pushed
the
perf-table-for-selection
branch
from
b4bd7e9 to
aafd093
Compare
marcelgerber
commented
Apr 12, 2024
Comment on lines
-106
to
-114
| const groupedByEntity = table | ||
| .groupBy(table.entityNameColumn.slug) | ||
| .map((t: OwidTable) => | ||
| t.dropRowsWithErrorValuesForAnyColumn(this.yColumnSlugs) | ||
| ) | ||
|
|
||
| if (groupedByEntity.length === 0) return BlankOwidTable() | ||
|
|
||
| table = groupedByEntity[0].concat(groupedByEntity.slice(1)) |
There was a problem hiding this comment.
Turns out, this here never needed the groupBy call at all: dropRowsWithErrorValuesForAnyColumn is entirely row-based, and decides on a row-by-row basis.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some performance problems with the
tableForSelectioncall, and specifically thetransformTableForSelectionmethod in chart instances, while reviewing #3447.So, I got at it and could quite improve these 🚀
What I did to check that this is correct:
I just loaded up 10-or-so different charts with
missingDataStrategy = 'hide', rangrapher.tableForSelection.dump(), and compared stats likenumRows,numValidCells, andnumErrorValuesacross live and localhost.They are all the same everywhere.