Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 (grapher) add CloseButton component #3434

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Apr 2, 2024

Cycle 2024.2: Entity selector (prep work) | Designs

Summary

Adds a reusable <CloseButton /> component that is used in a number of places:

  • In modals
  • In the settings popup
  • In the slide-in drawer

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, and great that you could identify & get rid of so many duplicate css styles. Love it!

@sophiamersmann sophiamersmann force-pushed the entity-selector-layout branch from fb54f50 to ff701c6 Compare April 8, 2024 10:08
@sophiamersmann sophiamersmann force-pushed the entity-selector-layout branch from ff701c6 to 02ed679 Compare April 9, 2024 14:28
@sophiamersmann sophiamersmann force-pushed the entity-selector-layout branch from 02ed679 to bef9234 Compare April 15, 2024 08:19
@sophiamersmann sophiamersmann force-pushed the entity-selector-layout branch from bef9234 to 2e584a7 Compare April 15, 2024 12:20
@owidbot
Copy link
Contributor

owidbot commented May 1, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-close-button

SVG tester: Number of differences (default views): 1237

Number of differences (all views): 389

Edited: 2024-05-01 14:06:24 UTC
Execution time: 1.23 seconds

Copy link
Member Author

sophiamersmann commented May 3, 2024

Merge activity

@sophiamersmann sophiamersmann force-pushed the entity-selector-layout branch from 5cf6c5b to 6b82c30 Compare May 3, 2024 08:05
Base automatically changed from entity-selector-layout to master May 3, 2024 08:07
@sophiamersmann sophiamersmann merged commit d391694 into master May 3, 2024
10 of 20 checks passed
@sophiamersmann sophiamersmann deleted the close-button branch May 3, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants