-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 (grapher) add CloseButton component #3434
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @sophiamersmann and the rest of your teammates on Graphite |
6fbe026
to
fb54f50
Compare
783e52b
to
36ba513
Compare
36ba513
to
a7d3911
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, and great that you could identify & get rid of so many duplicate css styles. Love it!
packages/@ourworldindata/grapher/src/closeButton/CloseButton.scss
Outdated
Show resolved
Hide resolved
a7d3911
to
913fa0c
Compare
fb54f50
to
ff701c6
Compare
913fa0c
to
ec6d30b
Compare
ff701c6
to
02ed679
Compare
ec6d30b
to
f24ea45
Compare
02ed679
to
bef9234
Compare
f24ea45
to
f7df677
Compare
bef9234
to
2e584a7
Compare
f7df677
to
c4f2b45
Compare
2e584a7
to
dfe898d
Compare
c4f2b45
to
146e6a7
Compare
dfe898d
to
a0cb03c
Compare
146e6a7
to
5cff74d
Compare
a0cb03c
to
037f115
Compare
5cff74d
to
0661b89
Compare
037f115
to
42ceb07
Compare
0661b89
to
71f1c62
Compare
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 1237Number of differences (all views): 389 Edited: 2024-05-01 14:06:24 UTC |
42ceb07
to
5cf6c5b
Compare
71f1c62
to
0856083
Compare
Merge activity
|
5cf6c5b
to
6b82c30
Compare
0856083
to
af674f4
Compare
Cycle 2024.2: Entity selector (prep work) | Designs
Summary
Adds a reusable
<CloseButton />
component that is used in a number of places: