🔨 migrate charts from typeorm to knex #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 6, 2024
Merged
danyx23
force-pushed
the
db-cleanup-posts-access
branch
from
a017102 to
3b3f0eb
Compare
danyx23
force-pushed
the
db-migrate-charts
branch
from
238800a to
2e741fe
Compare
.vscode/launch.json
Outdated
| @@ -104,6 +104,7 @@ | |||
| "program": "${workspaceFolder}/itsJustJavascript/adminSiteServer/app.js", | |||
| "request": "launch", | |||
| "type": "node", | |||
| "runtimeExecutable": "/mnt/wslg/runtime-dir/fnm_multishells/5693_1709636182174/bin/node" | |||
There was a problem hiding this comment.
Don't think this should go here.
| @@ -156,6 +156,12 @@ export const knexRawFirst = async <TRow = unknown>( | |||
| return results[0] | |||
| } | |||
|
|
|||
| export const knexRawInsert = async ( | |||
There was a problem hiding this comment.
Should we rather enforce a KnexReadWriteTransaction to be safe?
(Likewise for the above knexRawFirst)
There was a problem hiding this comment.
Yeah good idea, in this case we can.
I'll make knexRawFirst take a RO transaction as this function is really for reading a single item I'd say
db/tests/basic.test.ts
Outdated
| await trx | ||
| .table(ChartsTableName) | ||
| .where({ id: 1 }) | ||
| .update({ isExplorable: 0 }) |
There was a problem hiding this comment.
Ugh, sophia is removing this one in #3323 currently, maybe use a different column :)
| @@ -17,7 +17,7 @@ const computeScore = (record: Omit<ChartRecord, "score">): number => { | |||
| const getChartsRecords = async ( | |||
| knex: db.KnexReadonlyTransaction | |||
| ): Promise<ChartRecord[]> => { | |||
| const chartsToIndex = await db.queryMysql(` | |||
| const chartsToIndex = await db.queryMysql(`-- sql | |||
There was a problem hiding this comment.
This one you can easily convert to trx-style.
danyx23
force-pushed
the
db-cleanup-posts-access
branch
2 times, most recently
from
6e9d27d to
5ef0579
Compare
danyx23
force-pushed
the
db-migrate-charts
branch
from
2e741fe to
89e40d9
Compare
danyx23
force-pushed
the
db-cleanup-posts-access
branch
from
9614859 to
bf9c363
Compare
danyx23
force-pushed
the
db-migrate-charts
branch
from
3691f92 to
34d125e
Compare
danyx23
force-pushed
the
db-cleanup-posts-access
branch
from
bf9c363 to
685334e
Compare
danyx23
force-pushed
the
db-migrate-charts
branch
from
34d125e to
5932a9e
Compare
This was referenced Mar 20, 2024
Merged
danyx23
force-pushed
the
db-cleanup-posts-access
branch
from
685334e to
8b9d87a
Compare
danyx23
force-pushed
the
db-migrate-charts
branch
from
5932a9e to
d12fa27
Compare
danyx23
force-pushed
the
db-cleanup-posts-access
branch
from
8b9d87a to
6a60379
Compare
danyx23
force-pushed
the
db-migrate-charts
branch
from
d12fa27 to
13fda36
Compare
danyx23
force-pushed
the
db-cleanup-posts-access
branch
from
6a60379 to
b1db3a1
Compare
danyx23
force-pushed
the
db-migrate-charts
branch
from
13fda36 to
e9db6b4
Compare
danyx23
force-pushed
the
db-cleanup-posts-access
branch
from
b1db3a1 to
338caee
Compare
danyx23
force-pushed
the
db-migrate-charts
branch
from
e9db6b4 to
710c3d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates database access to the charts table and the chart_revisions table to knex