Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 reorder parameters of knexRaw and knexRawFirst to have knex in first pos #3258

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Feb 28, 2024

Reorders the parameters of the knexRaw and knexRawFirst functions so that the knex instance comes first

Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man, that was a lot of places that needed to be touched... thank you for doing all this work!

@danyx23 danyx23 force-pushed the db-knex-reorder-params branch from 6cdbb4d to 549391a Compare March 26, 2024 11:44
Copy link
Contributor Author

danyx23 commented Mar 26, 2024

Merge activity

  • Mar 26, 10:04 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Mar 26, 10:05 AM EDT: @danyx23 merged this pull request with Graphite.

@danyx23 danyx23 merged commit c4128e2 into master Mar 26, 2024
30 of 32 checks passed
@danyx23 danyx23 deleted the db-knex-reorder-params branch March 26, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants