🐝 eslint fixes

owid · Mar 15, 2024 · 89e40d9 · 89e40d9
1 parent 0f7356e
commit 89e40d9
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/adminSiteServer/testPageRouter.tsx b/adminSiteServer/testPageRouter.tsx
@@ -5,7 +5,6 @@ import React from "react"
 
 import { renderToHtmlPage, expectInt } from "../serverUtils/serverUtil.js"
 import {
-    Chart,
     getChartConfigBySlug,
     getChartVariableData,
 } from "../db/model/Chart.js"

diff --git a/baker/algolia/indexExplorersToAlgolia.ts b/baker/algolia/indexExplorersToAlgolia.ts
@@ -14,7 +14,6 @@ import { ALGOLIA_INDEXING } from "../../settings/serverSettings.js"
 import { getAnalyticsPageviewsByUrlObj } from "../../db/model/Pageview.js"
 import { chunkParagraphs } from "../chunk.js"
 import { SearchIndexName } from "../../site/search/searchTypes.js"
-import { Chart } from "../../db/model/Chart.js"
 
 type ExplorerBlockColumns = {
     type: "columns"

diff --git a/db/model/Chart.ts b/db/model/Chart.ts
@@ -124,14 +124,14 @@ export async function getEnrichedChartBySlug(
     knex: db.KnexReadonlyTransaction,
     slug: string
 ): Promise<DbEnrichedChart | null> {
-    const chart = await db.knexRawFirst<DbRawChart>(
+    let chart = await db.knexRawFirst<DbRawChart>(
         knex,
         `SELECT * FROM charts WHERE config ->> '$.slug' = ?`,
         [slug]
     )
 
     if (!chart) {
-        const chart = await db.knexRawFirst<DbRawChart>(
+        chart = await db.knexRawFirst<DbRawChart>(
             knex,
             `select c.*
             from chart_slug_redirects csr

diff --git a/db/tests/basic.test.ts b/db/tests/basic.test.ts
@@ -79,7 +79,7 @@ test("timestamps are automatically created and updated", async () => {
             config: "{}",
             lastEditedAt: new Date(),
             lastEditedByUserId: 1,
-            isExplorable: 1,
+            is_indexable: 0,
         }
         await trx.table(ChartsTableName).insert(chart)
         const created = await knexRawFirst<DbRawChart>(
@@ -95,7 +95,7 @@ test("timestamps are automatically created and updated", async () => {
             await trx
                 .table(ChartsTableName)
                 .where({ id: 1 })
-                .update({ isExplorable: 0 })
+                .update({ is_indexable: 1 })
             const updated = await knexRawFirst<DbRawChart>(
                 trx,
                 "select * from charts where id = 1",