✨ unify transaction creation and close db connection in same call for scripts #3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 16, 2024
Merged
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
fe40423 to
e559c80
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
2 times, most recently
from
f4fc806 to
4816ba2
Compare
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
94180e6 to
445e098
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
from
9855cf0 to
402126d
Compare
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
445e098 to
c968925
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
2 times, most recently
from
57e6709 to
b469dca
Compare
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
c968925 to
79b18e1
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
from
b469dca to
96b52a3
Compare
Merged
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
79b18e1 to
73526be
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
from
96b52a3 to
1406f03
Compare
ikesau
approved these changes
Mar 21, 2024
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
73526be to
1be5ef4
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
from
1406f03 to
b444008
Compare
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
1be5ef4 to
f8026fa
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
from
b444008 to
25902dd
Compare
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
f8026fa to
65f7d9d
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
from
25902dd to
3631bdb
Compare
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
65f7d9d to
24084b8
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
from
3631bdb to
7dc065f
Compare
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
24084b8 to
299207d
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
from
7dc065f to
77a4d15
Compare
danyx23
force-pushed
the
db-cleanup-after-big-db-refactor
branch
from
299207d to
63d6d63
Compare
danyx23
force-pushed
the
db-autocleanup-for-scripts
branch
from
77a4d15 to
cc52aec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new parameter for the transaction creation functions that closes the database connection. This is useful for scripts which usually want to run stuff in one transaction and would then like to have the DB connection closes. For the api router the option is not used of course as it is a long running process.