Add author work

[mlbrgl]

staging preview, gdoc

•  responsive styles
• update hover / visited styles

👉 See this comment for some of the more structural decisions I made.

Only consider the "🌑 Dark launch" scope from the tracking issue

[mlbrgl]

• Author pages: pre-launch additions #3484
• Author pages: design review #3348
• feat(author): bake author gdocs #3322
• Add author work #3257 👈
• Add author header #3256
• refactor(baker): allow bake dirs for all gdoc types #3310
• fix(r&w): tablet styles for first featured article #3302
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mlbrgl and the rest of your teammates on Graphite

[mlbrgl]

@ikesau I'd be curious to hear whether this adjustment to parsing images in a block, whose content is dynamically generated, fits your mental model of image handling.

[danyx23]

I don't understand this comment - can you give me a bit of context for this one? Is this a concern because of lightning baking? Why can we not just iterate over the latest work and collect the featured-images?

[mlbrgl]

Why can we not just iterate over the latest work and collect the featured-images?

@danyx23 I'm assuming you're referring to

owid-grapher/db/model/Gdoc/GdocBase.ts

Lines 276 to 286 in 904b82c

	get linkedImageFilenames(): string[] {
	// The typing logic is a little strange here
	// `featured-image` isn't guaranteed to be on all types of Gdoc (it's a GdocPost thing)
	// but we try (and then filter nulls) because we need featured images if we're using prominent links
	// even if this method is being called on a GdocFaq (for example)
	const featuredImages = Object.values(this.linkedDocuments)
	.map((d) => d["featured-image"])
	.filter((filename?: string): filename is string => !!filename)
	return [...this.filenames, ...featuredImages]
	}

In this snippet this.linkedDocuments originate from this.links, which is populated in parallel to Link.createFromUrl calls, which create rows in the posts_gdocs_links table.

These links only get refreshed when updating/deleting a gdoc in the admin:

owid-grapher/adminSiteServer/apiRouter.ts

Lines 2465 to 2469 in 904b82c

	await Link.delete({
	source: {
	id: id,
	},
	})

The problem is that there won't be an admin action for every update to the latest work block, which is updated dynamically whenever a new article by a given author is published/unpublished. So the posts_gdocs_links table will gradually fall out of sync.

By contrast, the featured work block is manually updated from content in the gdoc itself, so modifying the block necessarily updates the posts_gdocs_links table.

[mlbrgl]

Merge activity

• Mar 15, 4:42 AM EDT: @mlbrgl started a stack merge that includes this pull request via Graphite.
• Mar 15, 4:43 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 15, 4:44 AM EDT: @mlbrgl merged this pull request with Graphite.