Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(author): bake author gdocs #3322

Merged
merged 1 commit into from
Mar 15, 2024
Merged

feat(author): bake author gdocs #3322

merged 1 commit into from
Mar 15, 2024

Conversation

mlbrgl
Copy link
Member

@mlbrgl mlbrgl commented Mar 8, 2024

  • Add baking of author pages (example on staging)
  • minor refactor of getPublishedGdocs() to getPublishedGdocPosts() for clarity

Bake on staging with:

yarn buildLocalBake http://staging-site-author-bake /home/owid/live-data/bakedSite --steps authors

@mlbrgl mlbrgl mentioned this pull request Mar 11, 2024
24 tasks
@mlbrgl mlbrgl force-pushed the author-bake branch 3 times, most recently from 3df1531 to 62aab47 Compare March 11, 2024 20:24
@mlbrgl mlbrgl marked this pull request as ready for review March 11, 2024 20:27
@mlbrgl mlbrgl requested a review from danyx23 March 11, 2024 20:28
@mlbrgl mlbrgl force-pushed the author-featured-work branch from 97e902a to a09413d Compare March 12, 2024 08:23
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine but on the staging server the latest work is not showing up. I haven't yet checked locally. Let me know if that is just a missing bake on staging or if I should try to repo locally.

@mlbrgl
Copy link
Member Author

mlbrgl commented Mar 13, 2024

@danyx23 my bad, I had linked to the previous PR's staging server. Link updated: http://staging-site-author-bake/team/hannah-ritchie

@mlbrgl mlbrgl requested a review from danyx23 March 13, 2024 16:14
@mlbrgl mlbrgl force-pushed the author-featured-work branch from 904b82c to ac52db5 Compare March 13, 2024 17:26
@mlbrgl
Copy link
Member Author

mlbrgl commented Mar 15, 2024

Merge activity

  • Mar 15, 4:42 AM EDT: @mlbrgl started a stack merge that includes this pull request via Graphite.
  • Mar 15, 4:46 AM EDT: Graphite rebased this pull request as part of a merge.
  • Mar 15, 4:47 AM EDT: @mlbrgl merged this pull request with Graphite.

@mlbrgl mlbrgl force-pushed the author-featured-work branch from ac52db5 to 2e9fee4 Compare March 15, 2024 08:43
Base automatically changed from author-featured-work to master March 15, 2024 08:44
@mlbrgl mlbrgl merged commit ee36037 into master Mar 15, 2024
15 of 19 checks passed
@mlbrgl mlbrgl deleted the author-bake branch March 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants