fix(vite): remove discrepancy between dev and prod css imports #3282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typography.scss
is imported twice:In
owid.entry.ts
, we're importing owid.scss then grapher.scss. This means that typography overrides defined in owid.scss, are being themselves overridden by grapher.scss's typography rules.👆 This is an example of the issue: both
.body-3-medium-italic
and.homepage-intro__featured-work-authors
have identical specificity (0,1,0), and yet the typography.scssline-height
unexpectedly takes over.In production, this isn't an issue since common is imported before owid.
... which leads to unnecessary !important overrides, simply to fix dev.