Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(r&w): font sizes and row gap #3263

Merged
merged 7 commits into from
Mar 4, 2024
Merged

fix(r&w): font sizes and row gap #3263

merged 7 commits into from
Mar 4, 2024

Conversation

mlbrgl
Copy link
Member

@mlbrgl mlbrgl commented Feb 28, 2024

closes #3265, #3264

Small design fixes to the research and writing block used on topic pages, and soon on author pages (#3224)

Testing page: http://staging-site-fix-style-research-writing/co2-and-greenhouse-gas-emissions#research-writing

see figma

@mlbrgl
Copy link
Member Author

mlbrgl commented Feb 28, 2024

@mrwbkrm
Copy link

mrwbkrm commented Feb 29, 2024

Hey @mlbrgl, this looks much better already. I have 2 notes:

  • the space between the section with Medium thumbnails and the title of the section with Small thumbnails is the same as the space between the title and the the Small thumbnails — it's not easy to explain so you'll see those 2 spaces highlighted with pink arrows in the screenshot. The space between the 2 sections should be bigger than the space between the title and the Small thumbnails within that section (I had them as 32 and 24 px respectively)
  • The spacing marked in purple is much bigger than the spacing between the medium thumbnails. I think 32px should be enough
Screenshot 2024-02-29 at 08 55 52

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code's fine by me once Marwa's happy how it looks 🙂

@mlbrgl mlbrgl changed the base branch from master to vite-dev-css-order March 2, 2024 18:45
@mlbrgl mlbrgl force-pushed the fix-style-research-writing branch from fb29e7d to 2b43452 Compare March 2, 2024 18:45
@mlbrgl
Copy link
Member Author

mlbrgl commented Mar 3, 2024

@mrwbkrm thanks! I reorganized things a bit internally and made the vertical margins more consistent and accurate across the whole block. I left you a comment in figma re grid gap in medium vs small thumbnails.

Updated http://staging-site-fix-style-research-writing/co2-and-greenhouse-gas-emissions#research-writing

@mlbrgl mlbrgl mentioned this pull request Mar 4, 2024
24 tasks
@mlbrgl
Copy link
Member Author

mlbrgl commented Mar 4, 2024

Row spacing is now different depending on the section:

  • medium thumbnails: 40px
  • small thumbnail: 32px

figma thread

@mlbrgl
Copy link
Member Author

mlbrgl commented Mar 4, 2024

Merge activity

  • Mar 4, 9:56 AM EST: @mlbrgl started a stack merge that includes this pull request via Graphite.
  • Mar 4, 9:58 AM EST: Graphite rebased this pull request as part of a merge.
  • Mar 4, 9:59 AM EST: @mlbrgl merged this pull request with Graphite.

Base automatically changed from vite-dev-css-order to master March 4, 2024 14:57
@mlbrgl mlbrgl force-pushed the fix-style-research-writing branch from 09336c6 to 751e8db Compare March 4, 2024 14:57
@mlbrgl mlbrgl merged commit 4749caa into master Mar 4, 2024
15 of 17 checks passed
@mlbrgl mlbrgl deleted the fix-style-research-writing branch March 4, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix font sizes on research and writing primary/secondary links
3 participants