Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sources modal: simplify CoreColumnDef #2794

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Sources modal: simplify CoreColumnDef #2794

merged 6 commits into from
Oct 27, 2023

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Oct 18, 2023 •
edited
Loading

Mild refactor of metadata handling in Grapher.

  • Cleans up CoreColumnDef to closer resemble the given metadata json hierarchy
    • In particular, source and a presentation objects are preserved

Other changes:

  • Enables keyboard shortcuts on data pages, and adds a shortcut for the sources modal (clicking s)

@sophiamersmann
Copy link
Member Author

sophiamersmann commented Oct 18, 2023 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

This was referenced Oct 18, 2023
Closed
Closed
@sophiamersmann sophiamersmann changed the title refactor(grapher): simplify CoreColumnDef Sources modal: simplify CoreColumnDef Oct 23, 2023
@sophiamersmann sophiamersmann force-pushed the refactor-grapher-core-column-def branch from 50902bb to 65381e0 Compare October 25, 2023 07:53
@sophiamersmann sophiamersmann marked this pull request as ready for review October 25, 2023 11:56
@sophiamersmann sophiamersmann force-pushed the refactor-grapher-core-column-def branch from 65381e0 to 4ca5e20 Compare October 25, 2023 12:57
@sophiamersmann sophiamersmann mentioned this pull request Oct 25, 2023
Merged
danyx23
danyx23 reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I'm confused about the type presentation - can you clarify that? Thanks!

danyx23
danyx23 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say let's just use the full object without the Pick

@sophiamersmann sophiamersmann force-pushed the refactor-grapher-core-column-def branch from 0b22570 to 4022482 Compare October 27, 2023 10:48
@sophiamersmann sophiamersmann merged commit 5081d4b into master Oct 27, 2023
13 checks passed
@sophiamersmann sophiamersmann deleted the refactor-grapher-core-column-def branch October 27, 2023 15:19
This was referenced Oct 30, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyx23 danyx23 danyx23 approved these changes

Assignees

@sophiamersmann sophiamersmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiamersmann @danyx23