Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explorer): show data source defined in explorer configs #2895

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

sophiamersmann
Copy link
Member

Reverts some changes made in #2794

Bug

  • Some explorer charts define source information in the explorer tsv config
  • That information is currently not taken into account, and no source is displayed (see screenshots)

What happened

  • Source properties used to be spread into the core column definition (as sourceName, sourceLink, etc)
  • The explorer's column grammar defines sourceName, sourceLink, etc. and sets these properties on the core column defintion
  • In Sources modal: simplify CoreColumnDef #2794, I removed sourceName, sourceLink, etc in favour of defining a source object that holds those properties
  • As a result, source information defined in the explorer config are ignored
Screenshot 2023-11-06 at 08 38 15 Screenshot 2023-11-06 at 09 51 55

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

@sophiamersmann sophiamersmann merged commit f08f0df into master Nov 6, 2023
20 checks passed
@sophiamersmann sophiamersmann deleted the fix-empty-source-in-explorers branch November 6, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants