Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oem/fv): Add fv_hulquminum_combine #10269

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Dec 16, 2023

Addresses the FV app portion of #2502

we don't see a recently added keyboard in the list anywhere to download (Hul̓q̓umin̓um̓/hulquminum_combine

This will need to 🍒 pick to stable-16.0

Note:

fv_hulquminum has name: Hul’q’umi’num’ (Hul\u2019q\u2019umi\u2019num\u2019)
fv_hulquminum_combine has name: Hul̓q̓umin̓um̓ (Hul\u0313q\u0313umin\u0313um\u0313)

Some future TODO's:

  • I wonder if keyboards.csv should be moved to the keyboards repo for FV staff to maintain.
  • ~15 other keyboards had older versions in the csv file. I'm not certain the version info is used (it's also in kmp.json).

Testing depends on keymanapp/keyboards#2504 getting merged

User Testing

Setup - Install the PR build of FV for Android or FV for iPhone and iPad

  • TEST_ANDROID - Verifies the latest versions of the 3 reported keyboards can be installed
  1. Install the PR build of FirstVoices for Android on an Android device/emulator
  2. Launch the FV App
  3. From the Setup menus, install the following keyboards (regions in parenthesis):
    • fv_southern_tutchone (Western Subarctic)
    • fv_hulquminum_combine (BC Coast)
    • fv_dane_zaa_zaage (Western Subarctic)
  4. From the FV setup menu, set FirstVoices as the default system keyboard
  5. Launch a separate app
  6. Switch through the FV keyboards and verify the following versions:
    • fv_southern_tutchone (9.2.1)
    • fv_hulquminum_combine (1.0)
    • fv_dane_zaa_zaage (9.3)
  7. Verify fv_southern_tutchone is not a plain QWERTY layout
  • TEST_IOS - Verifies the latest versions of the 3 reported keyboards can be installed
  1. Install the PR build of FirstVoices for iPhone and iPad on an iOS device/emulator
  2. Launch the FV App
  3. From the Setup menus, install the following keyboards (regions in parenthesis):
    • fv_southern_tutchone (Western Subarctic)
    • fv_hulquminum_combine (BC Coast)
    • fv_dane_zaa_zaage (Western Subarctic)
  4. From the FV setup menu, set FirstVoices as the default system keyboard
  5. Launch a separate app
  6. Switch through the FV keyboards and verify the following versions:
    • fv_southern_tutchone (9.2.1)
    • fv_hulquminum_combine (1.0)
    • fv_dane_zaa_zaage (9.3)
  7. Verify fv_southern_tutchone is not a plain QWERTY layout

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Dec 16, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 16, 2023

User Test Results

Test specification and instructions

  • TEST_ANDROID (PASSED): Retested with the attached PR build (First Voices)in the Android Mobile device (ver 13) and here is my observation: 1. Installed southern_tutchone (Western Subarctic), Hul̓q̓umin̓um̓ (BC Coast) and dane_zaa_zaage (Western Subarctic) keyboards from First Voices. 2. Set the FirstVoices as the default system keyboard. 3. Open Chrome browser app. 4. Clicked on the Google Search bar. 5. Opened the FirstVoices Keyboard picker menu. 5. Noticed that Suthern_Tutchone keyboard version was changed from 9.2.1 to 9.2.2. 6. From the southern_tutchone help topic, it is confirmed the southern_tutchone keyboard layout was not an ordinary QWERTY keyboard layout. ie., instead of q it shows ä in the first row. (notes)
  • TEST_IOS (PASSED): Retested with the attached PR build (First Voices)in the iOS 17.0 / iPhone 15 Pro Max Simulator and here is my observation: 1. Installed southern_tutchone (Western Subarctic), Hul̓q̓umin̓um̓ (BC Coast) and dane_zaa_zaage (Western Subarctic) keyboards from First Voices. 2. Set the FirstVoices as the default system keyboard. 3. Open Chrome browser app. 4. Clicked on the Google Search bar. 5. Opened the FirstVoices Keyboard picker menu. 5. Noticed that Suthern_Tutchone keyboard version was changed from 9.2.1 to 9.2.2. 6. From southern_tutchone help topic, it is confirmed the southern_tutchone keyboard layout was not an ordinary QWERTY keyboard layout. ie., instead of q it shows ä in the first row. (notes)

Test Artifacts

Copy link
Contributor

@rc-swag rc-swag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bharanidharanj
Copy link

Test Results

  • TEST_ANDROID (FAILED): Tested with the attached PR build (First Voices)in the Android Mobile device (ver 13) and here is my observation: 1. Installed southern_tutchone (Western Subarctic), Hul̓q̓umin̓um̓ (BC Coast) and dane_zaa_zaage (Western Subarctic) keyboards from First Voices. 2. Set the FirstVoices as the default system keyboard. 3. Open Chrome browser app. 4. Clicked on the Google Search bar. 5. Opened the FirstVoices Keyboard picker menu. 5. Noticed that Suther Tutchone keyboard version is 9.2.2. 6. Verified that the southern_tutchone is seems to be qwerty layout(?).

..Southern Tutchone version

..Seems to be qwerty keyboard

@bharanidharanj
Copy link

Test Results

  • TEST_IOS (FAILED): Tested with the attached PR build (First Voices)in the iOS 17.0 / iPhone 15 Pro Max Simulator and here is my observation: 1. Installed southern_tutchone (Western Subarctic), Hul̓q̓umin̓um̓ (BC Coast) and dane_zaa_zaage (Western Subarctic) keyboards from First Voices. 2. Set the FirstVoices as the default system keyboard. 3. Open Chrome browser app. 4. Clicked on the Google Search bar. 5. Opened the FirstVoices Keyboard picker menu. 5. Noticed that Suther Tutchone keyboard version is 9.2.2. 6. Verified that the southern_tutchone is seems to be qwerty layout(?).

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Dec 19, 2023
@darcywong00
Copy link
Contributor Author

darcywong00 commented Dec 19, 2023

@bharanidharanj the layout looks to have "a" instead of "q". Please retest because it looks like the layout does match https://help.keyman.com/keyboard/fv_southern_tutchone/9.2.2/fv_southern_tutchone

@keymanapp-test-bot retest

@keymanapp-test-bot keymanapp-test-bot bot added user-test-required User tests have not been completed and removed user-test-failed labels Dec 19, 2023
@bharanidharanj
Copy link

bharanidharanj commented Dec 19, 2023

Test Results

  • TEST_ANDROID (PASSED): Retested with the attached PR build (First Voices)in the Android Mobile device (ver 13) and here is my observation: 1. Installed southern_tutchone (Western Subarctic), Hul̓q̓umin̓um̓ (BC Coast) and dane_zaa_zaage (Western Subarctic) keyboards from First Voices. 2. Set the FirstVoices as the default system keyboard. 3. Open Chrome browser app. 4. Clicked on the Google Search bar. 5. Opened the FirstVoices Keyboard picker menu. 5. Noticed that Suthern_Tutchone keyboard version was changed from 9.2.1 to 9.2.2. 6. From the southern_tutchone help topic, it is confirmed the southern_tutchone keyboard layout was not an ordinary QWERTY keyboard layout. ie., instead of q it shows ä in the first row.

  • TEST_IOS (PASSED): Retested with the attached PR build (First Voices)in the iOS 17.0 / iPhone 15 Pro Max Simulator and here is my observation: 1. Installed southern_tutchone (Western Subarctic), Hul̓q̓umin̓um̓ (BC Coast) and dane_zaa_zaage (Western Subarctic) keyboards from First Voices. 2. Set the FirstVoices as the default system keyboard. 3. Open Chrome browser app. 4. Clicked on the Google Search bar. 5. Opened the FirstVoices Keyboard picker menu. 5. Noticed that Suthern_Tutchone keyboard version was changed from 9.2.1 to 9.2.2. 6. From southern_tutchone help topic, it is confirmed the southern_tutchone keyboard layout was not an ordinary QWERTY keyboard layout. ie., instead of q it shows ä in the first row.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Dec 19, 2023
@darcywong00 darcywong00 merged commit 1c216bb into master Dec 19, 2023
6 checks passed
@darcywong00 darcywong00 deleted the fix/fv/keyboards-csv branch December 19, 2023 11:08
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.233-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fv_all] - Some keyboards are not the latest
4 participants