Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oem/fv): Add fv_kwadacha_tsekene #10292

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

darcywong00
Copy link
Contributor

Similar to #10269

While auditing keyboards.csv with the kmp.json file from fv_all.kmp, I saw the mobile apps need an entry for fv_kwadacha_tsekene.

Will need to 🍒 pick to stable-16.0 (or add to #10285)

Tagging @caforbes

User Testing

Setup - Install the PR build of FV for Android or FV for iPhone and iPad

  • TEST_ANDROID - Verifies fv_kwadacha_tsekene can be installed
  1. Install the PR build of FirstVoices for Android on an Android device/emulator
  2. Launch the FV App
  3. From the Setup menus, install the following keyboards (regions in parenthesis):
    • fv_kwadacha_tsekene (BC Interior)
  4. From the FV setup menu, set FirstVoices as the default system keyboard
  5. Launch a separate app
  6. Switch through the FV keyboards and verify the following version:
    • fv_kwadacha_tsekene (1.0)
  • TEST_IOS - Verifies fv_kwadacha_tsekene can be installed
  1. Install the PR build of FirstVoices for iPhone and iPad on an iOS device/emulator
  2. Launch the FV App
  3. From the Setup menus, install the following keyboards (regions in parenthesis):
    • fv_kwadacha_tsekene (BC Interior)
  4. From the FV setup menu, set FirstVoices as the default system keyboard
  5. Launch a separate app
  6. Switch through the FV keyboards and verify the following version:
    • fv_kwadacha_tsekene (1.0)

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Dec 21, 2023
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Dec 21, 2023

User Test Results

Test specification and instructions

  • TEST_ANDROID (PASSED): Tested with the attached PR build 17.0.235-alpha-test-10292 in the Android Mobile device (ver 13) and here is my observation: 1. Launched FirstVoices App. 2. Installed fv_kwadacha_tsekene (BC Interior). 3. Set FirstVoices as the default system keyboard. 4. Opened the OSK in a separate app. (eg., Chrome browser). 5. Verified the version number is 1.0. (notes)
  • TEST_IOS (PASSED): Tested with the attached PR build 17.0.235-alpha-test-10292 in iOS 17.0 / iPhone 15 Pro Max Simulator and here is my observation: 1. Launched FirstVoices App. 2. Installed fv_kwadacha_tsekene (BC Interior). 3. Verified the version number is 1.0. 4. Set FirstVoices as the default system keyboard. 5. Opened the OSK in a separate app. (eg., Safari browser). (notes)

Test Artifacts

@bharanidharanj
Copy link

Test Results

  • TEST_ANDROID (PASSED): Tested with the attached PR build 17.0.235-alpha-test-10292 in the Android Mobile device (ver 13) and here is my observation: 1. Launched FirstVoices App. 2. Installed fv_kwadacha_tsekene (BC Interior). 3. Set FirstVoices as the default system keyboard. 4. Opened the OSK in a separate app. (eg., Chrome browser). 5. Verified the version number is 1.0.

..FV as default keyboard

..FV version

@bharanidharanj
Copy link

Test Results

  • TEST_IOS (PASSED): Tested with the attached PR build 17.0.235-alpha-test-10292 in iOS 17.0 / iPhone 15 Pro Max Simulator and here is my observation: 1. Launched FirstVoices App. 2. Installed fv_kwadacha_tsekene (BC Interior). 3. Verified the version number is 1.0. 4. Set FirstVoices as the default system keyboard. 5. Opened the OSK in a separate app. (eg., Safari browser).

..FV version

..FV keyboard in Safari browser

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Dec 21, 2023
@darcywong00 darcywong00 merged commit 91eec31 into master Dec 22, 2023
7 checks passed
@darcywong00 darcywong00 deleted the fix/oem/fv/kwadacha_tsekene branch December 22, 2023 02:26
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.236-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants