Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oem/fv): Update versions in keyboards.csv #10606

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

darcywong00
Copy link
Contributor

Follows #10269 and #10292

The OEM FV apps currently still use keyboards.csv to associate regions for keyboards.
At least in the Android app, the keyboard versions from the csv file are also used (read before fv_all.kmp is extracted and kmp.json is available).

This just bumps the applicable keyboard versions based on kmp.json from fv_all.kmp v 12.6

@keymanapp-test-bot skip

@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

@mcdurdin
Copy link
Member

mcdurdin commented Feb 2, 2024

Does this mean 16.0.145 has old versions of keyboards?

@darcywong00
Copy link
Contributor Author

Does this mean 16.0.145 has old versions of keyboards?

16.0.145 contains and uses the new versions of the keyboards, but the app "lists" the versions per the keyboards.csv file.

@darcywong00 darcywong00 merged commit 1fdbfd8 into master Feb 3, 2024
5 checks passed
@darcywong00 darcywong00 deleted the chore/fv/keyboards-csv/version branch February 3, 2024 01:26
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.260-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants