-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(oem/fv): Add fv_hulquminum_combine and fv_kwadacha_tsekene 🍒 🏠 #10285
Conversation
User Test ResultsTest specification and instructions
Test Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@bharanidharanj - Did the globe key on the FV keyboard let you switch to other FV keyboards? |
No, @darcywong00 The globe key does not allow me to switch to other FV keyboards. Seems to be an issue. |
I'm confused why the FV keyboard shows EuroLatin and won't switch to others. Can you retest on a physical iOS device? @keymanapp-test-bot retest TEST_IOS |
Test Results
@darcywong00 Tried to download the FirstVoices in the real iPhone 13 mobile and noticed that the TestFlight only downloads the Keyman build. It would be better to attach the FirstVoices build (TestFlight internal version). |
@darcywong00 Yes. After switching to FV keyboard, it shows EuroLatin keyboard instead of FV keyboard. |
@bharanidharanj and @sgschantz were able to get TestFlight to load PR builds on a device, so let's try testing iOS again |
Ah, I had to re-trigger another iOS build to get that in. (The triggers don't make a build when just changing the .csv file) @keymanapp-test-bot retest TEST_IOS |
Changes in this pull request will be available for download in Keyman version 16.0.145 |
🍒 pick of #10269 and #10292 to stable-16.0
Addresses the FV app portion of #2502 for 16.0
Also adds fv_kwadacha_tsekene
Note:
fv_hulquminum has name:
Hul’q’umi’num’
(Hul\u2019q\u2019umi\u2019num\u2019)fv_hulquminum_combine has name:
Hul̓q̓umin̓um̓
(Hul\u0313q\u0313umin\u0313um\u0313)User Testing
Setup - Install the PR build of FV for Android or FV for iPhone and iPad