Skip to content

SteeringReview130412

Sebastian Schmieschek edited this page Aug 12, 2015 · 2 revisions

Notes from JH review of the steering namespace in Milestone 0.2.3

Freeform initial notes

MapType should have a better name Map used for determining imaging start/end should be a class Simulation master's snapshotsCompleted should be called localImageCompletionSchedule, sim'ly for networkImagesCompleted CalculateMouseFlowField should be refactored to have a method on lb which is not aware of UI concepts, and keep UI concepts such as mouse coordinate conversion elsewhere. Lots of floats and doubles should use PhysicalStress, ScreenStress, LatticeStress typedefs etc. The Phased Broadcast system has lots of points of overridability. Is this overcomplex? Is there a wikidoc on the phased broadcast system? Is the Rondezvous Code in ClientConnection via bunsen.chem.ucl.ac.uk actually used for the standalone client? We're using system-level TCP/IP sockets. Is there a better choice? TODO in SteeringComponent::Effect seems like it needs attention.

Clone this wiki locally