-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(staking): preview dialog for in-app staking + unstaking #742
Merged
moo-onthelawn
merged 8 commits into
main
from
mulan/ote-473-confirm-state-for-stakeunstake
Jul 3, 2024
Merged
feat(staking): preview dialog for in-app staking + unstaking #742
moo-onthelawn
merged 8 commits into
main
from
mulan/ote-473-confirm-state-for-stakeunstake
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
moo-onthelawn
changed the title
feat(staking): preview dialog for in-app staking
feat(staking): (1/2) preview dialog for in-app staking
Jun 28, 2024
moo-onthelawn
force-pushed
the
mulan/ote-473-confirm-state-for-stakeunstake
branch
from
July 2, 2024 20:13
114701f
to
010dfaf
Compare
moo-onthelawn
changed the title
feat(staking): (1/2) preview dialog for in-app staking
feat(staking): preview dialog for in-app staking + unstaking
Jul 2, 2024
moo-onthelawn
force-pushed
the
mulan/ote-473-confirm-state-for-stakeunstake
branch
from
July 2, 2024 20:25
010dfaf
to
56a94a3
Compare
moo-onthelawn
force-pushed
the
mulan/ote-473-confirm-state-for-stakeunstake
branch
from
July 2, 2024 20:46
56a94a3
to
89da9e0
Compare
rosepuppy
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job re-organizing! very cleanly done 🔥
@@ -174,4 +174,25 @@ export const formMixins = { | |||
--form-input-gap: 1rem; | |||
} | |||
`, | |||
|
|||
stakingForm: css` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet!
This was referenced Jul 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially:
Now:
Views
New:
views/forms/StakingForms/shared/StakePreviewContents
StakeFormPreviewContents
andUnstakeFormPreviewContents
New:
views/forms/StakingForms/shared/StakeConfirmationButtonRow
StakePreviewContents
Moved:
views/StakeRewardButtonAndReceipt
->views/forms/StakingForms/shared/StakeRewardButtonAndReceipt
StakePreviewContents
Moved:
components/ValidatorName
->views/forms/StakingForms/shared/ValidatorName
StakeDialog
StakeForm/index.ts
- moveddescription
intodescription
prop ofDialog
andLegalDisclaimer
intofooter
propStakeForm
(moved fromforms/StakeForm
->forms/StakingForms/StakeForm
)StakeFormInputContents
andStakeFormPreviewContents
Deleted:
StakeButtonAndReceipt
, encapsulated into new:StakeFormInputContents
New:
StakeFormPreviewContents
UnstakeDialog
UnstakeForm/index.ts
- moveddescription
intodescription
prop ofDialog
UnstakeForm
(moved fromforms/UnstakeForm
->forms/StakingForms/UnstakeForm
)Deleted:
UnstakeButtonAndReceipt
, encapsulated into new:UnstakeFormInputContents
New:
UntakeFormPreviewContents
Components
New:
FastForwardIcon
New:
components/ValidatorIcons
ValidatorFaviconIcon
s slightly overlapping each otherValidatorFaviconIcon
extracted into own component incomponents/
(fromValidatorName
)ValidatorName
in several placesStyles/Mixins
styles/formMixins
stakingForm
mixin forUnstakeForm
andStakeForm
styles/layoutMixins
textLineClamp
which truncates text at 2 linesConstants/Types
constants/stakingForms.ts
StakeFormSteps
currently used byStakeDialog
, will be used byUnstakeDialog
Packages
package.json
localization