Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative fix for a crash and connectivity issues #2933

Merged

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Jul 3, 2024

Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

BSK PR: duckduckgo/BrowserServicesKit#875
iOS PR: duckduckgo/iOS#3027

What kind of version bump will this require?: Patch

Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.

Testing:

  • Make sure the VPN starts and stops correctly.
  • Make sure the connection works after sleeping and waking the device.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the project file change didn't get checked in here, but I fixed it locally for testing as long as it's bumped to be set to the tag before merging we're good. 👍

diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

iOS PR: duckduckgo/iOS#3027
macOS PR: duckduckgo/macos-browser#2933

What kind of version bump will this require?: Patch

## Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.
diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

iOS PR: duckduckgo/iOS#3027
macOS PR: duckduckgo/macos-browser#2933

What kind of version bump will this require?: Patch

## Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.
@diegoreymendez diegoreymendez changed the base branch from main to release/1.95.0 July 3, 2024 09:24
diegoreymendez added a commit to duckduckgo/iOS that referenced this pull request Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

BSK PR: duckduckgo/BrowserServicesKit#875
macOS PR: duckduckgo/macos-browser#2933

What kind of version bump will this require?: Patch

## Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.
@diegoreymendez diegoreymendez merged commit 0337111 into release/1.95.0 Jul 3, 2024
25 checks passed
@diegoreymendez diegoreymendez deleted the diego/tentative-fix-tunnel-start-crash branch July 3, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants