Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative fix for a crash and connectivity issues #3027

Merged

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Jul 3, 2024

Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

BSK PR: duckduckgo/BrowserServicesKit#875
macOS PR: duckduckgo/macos-browser#2933

What kind of version bump will this require?: Patch

Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.

Testing:

  • Make sure the VPN starts and stops correctly.
  • Make sure the connection works after sleeping and waking the device.

Checklists

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

iOS PR: duckduckgo/iOS#3027
macOS PR: duckduckgo/macos-browser#2933

What kind of version bump will this require?: Patch

## Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.
diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

iOS PR: duckduckgo/iOS#3027
macOS PR: duckduckgo/macos-browser#2933

What kind of version bump will this require?: Patch

## Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.
@diegoreymendez diegoreymendez changed the base branch from main to release/7.127.0 July 3, 2024 09:24
@diegoreymendez diegoreymendez merged commit 213d282 into release/7.127.0 Jul 3, 2024
20 checks passed
@diegoreymendez diegoreymendez deleted the diego/tentative-fix-tunnel-start-crash branch July 3, 2024 11:12
diegoreymendez added a commit to duckduckgo/macos-browser that referenced this pull request Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

BSK PR: duckduckgo/BrowserServicesKit#875
iOS PR: duckduckgo/iOS#3027

What kind of version bump will this require?: Patch

## Description

This PR tries to fix a VPN extension crash and some potential
connectivity issues.
samsymons added a commit that referenced this pull request Jul 4, 2024
* main: (24 commits)
  Add pixels to measure baseline for New Tab Page sections (#3024)
  backgrounding UI tests (#3021)
  improve bookmarks and favorites UI tests (#3019)
  [DuckPlayer] - 4. Remote Config (#3018)
  Updates BSK
  Fix issue when cancelling a download (#3030)
  Tentative fix for a crash and connectivity issues (#3027)
  autofill UI tests (#3012)
  scripts for running UI tests (#3000)
  Integrate RemoteMessaging with NewTabPage (#3017)
  Update to iOS 15 deployment target (#3001)
  Fire a pixel when removing the VPN configuration (#3014)
  Release 7.127.0-0 (#3020)
  point to BSK branch (#3016)
  [DuckPlayer] - 3. URL management & FE comms (#3007)
  Bump BSK version (#3011)
  New Tab Page layout and base elements (#3008)
  Remove Privacy Pro from device once expired account is deleted (#3009)
  Improvements to subscription settings (#2959)
  Toggle reports limiter (#3005)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants