Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative fix for a crash and connectivity issues #875

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Jul 3, 2024

Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

iOS PR: duckduckgo/iOS#3027
macOS PR: duckduckgo/macos-browser#2933

What kind of version bump will this require?: Patch

Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.

Testing:

Please refer to the platform-specific PRs.


Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me 👍

@diegoreymendez diegoreymendez merged commit 40e456e into main Jul 3, 2024
14 checks passed
@diegoreymendez diegoreymendez deleted the diego/tentative-fix-tunnel-start-crash branch July 3, 2024 09:17
diegoreymendez added a commit that referenced this pull request Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

iOS PR: duckduckgo/iOS#3027
macOS PR: duckduckgo/macos-browser#2933

What kind of version bump will this require?: Patch

## Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.
diegoreymendez added a commit to duckduckgo/iOS that referenced this pull request Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

BSK PR: duckduckgo/BrowserServicesKit#875
macOS PR: duckduckgo/macos-browser#2933

What kind of version bump will this require?: Patch

## Description

This PR tries to fix a VPN extension crash and some potential connectivity issues.
diegoreymendez added a commit to duckduckgo/macos-browser that referenced this pull request Jul 3, 2024
Task/Issue URL: https://app.asana.com/0/0/1207717985731035/f

BSK PR: duckduckgo/BrowserServicesKit#875
iOS PR: duckduckgo/iOS#3027

What kind of version bump will this require?: Patch

## Description

This PR tries to fix a VPN extension crash and some potential
connectivity issues.
samsymons added a commit that referenced this pull request Jul 4, 2024
* main:
  Tentatively fixes connectivity and tunnel start issues (#875)
  Tentatively fixes connectivity and tunnel start issues (#875)
  update reference to C-S-S (#871)
  Autoplay settings (#872)
  Fix same-document navigation breaking current main frame navigation (#873)
  Remove Privacy Pro from device once expired account is deleted (#870)
  Make entitlements var public (#867)
  Toggle reports limiter (#868)
  Silence tunnel startup noise with no access token available (#863)
  Fixes an issue when uninstalling the VPN over UDS, where the menu app wouldn't quit (#866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants