deps: update to cosmos-sdk v0.52 (Olympus) #7261
Conversation
tac0turtle
force-pushed
the
marko/gomod_change
branch
from
2bb67b5 to
0832575
Compare
Co-authored-by: DimitrisJim <[email protected]>
…authKeeper where apt
| @@ -641,7 +641,7 @@ func (suite *KeeperTestSuite) TestJSONOnRecvPacket() { | |||
| "messages": [], | |||
| "metadata": "ipfs://CID", | |||
| "title": "IBC Gov Proposal", | |||
| "summary": "tokens for all!", | |||
| "summary": "tokens for some, miniature American flags for others!", | |||
|
There was a problem hiding this comment.
finished all files. Idea of merging and taking care of some things post merge sounds good to me.
Thanks so much @tac0turtle for initial work and @damiannolan and @chatton for powering through with it!
| ante.NewValidateMemoDecorator(options.AccountKeeper), | ||
| ante.NewConsumeGasForTxSizeDecorator(options.AccountKeeper), | ||
| ante.NewDeductFeeDecorator(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper, options.TxFeeChecker), | ||
| ante.NewSetPubKeyDecorator(options.AccountKeeper), // SetPubKeyDecorator must be called before all signature verification decorators |
There was a problem hiding this comment.
trusting this comment is still valid and handled by the new NewSigVerificationDecorator handler that appears to encompass all ones that are now removed
There was a problem hiding this comment.
I think so! But I didn't verify
There was a problem hiding this comment.
Happy to move forward with this to main now. I've created a number of issues to follow up with and I will continue migrating the rest of the codebase to use appmodule.Environment
Thanks to everyone who contributed on this PR and to the SDK team for their responsiveness in addressing any issues that came up from it.
The last blocking issue listed in the description is in relation to client encoding of txs which directly affects testing compatibility and upgrade tests. This is being actively worked on and I think it can be resolved soon ™️
edit: note that build (arm) was removed but is still showing as a required check on PR. This doesn't matter anymore
There was a problem hiding this comment.
This could use more love too at some point
removed as required check! |
| @@ -42,7 +42,7 @@ const ( | |||
| // ChainBRelayerName is the name given to the relayer wallet on ChainB | |||
| ChainBRelayerName = "rlyB" | |||
| // DefaultGasValue is the default gas value used to configure tx.Factory | |||
| DefaultGasValue = 500_000_0000 | |||
| DefaultGasValue = 100_000_00 | |||
There was a problem hiding this comment.
yeah, would be interesting to understand if this is because it was sent too high in the first place, or the sdk somehow requires less? Not very important if this value works (although, should it not be 10_000_000? :D )
Description
Updates ibc-go to cosmos-sdk olympus release.
We will also migrate to use
runtime.Environment. Currently this PR only migrates icacontroller toruntime.Environmentto fix test failures which suffered from loss of event propagation when usingUnwrapSDKContextdue to event emission on a copy.Blocking issues:
** Required for compatability tests and E2E upgrade tests as client code working on v0.52 is incompatible against older node software
closes: #7223
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.