Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate errors in favour of panicking in genesis funcs (v0.52/olympus) #7698

Open
damiannolan opened this issue Dec 17, 2024 · 1 comment
Open

Propagate errors in favour of panicking in genesis funcs (v0.52/olympus) #7698

damiannolan opened this issue Dec 17, 2024 · 1 comment
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Milestone
v10.0.0

Comments

@damiannolan
Copy link
Member

Remove panic calls from genesis funcs in ibc.

We can now propagate errors and let them be handled gracefully from cosmos-sdk in genesis funcs.

Pending #7261

do we want to update sig to return error here too? Most of functions invoked in here currently go the ol' panic route in most cases. Does sdk panic on returned error during genesis ops?

Originally posted by @DimitrisJim in #7261 (comment)
@damiannolan damiannolan added the type: code hygiene Clean up code but without changing functionality or interfaces label Dec 17, 2024
@damiannolan damiannolan added this to the v10.0.0 milestone Dec 17, 2024
@damiannolan damiannolan mentioned this issue Dec 17, 2024
Merged
10 tasks
@Sruthi2357
Copy link

Shall I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
IBC-GO Eureka
Status: Backlog
Milestone
v10.0.0
Development

No branches or pull requests
2 participants
@damiannolan @Sruthi2357