Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently name context variable #7702

Open
4 tasks
DimitrisJim opened this issue Dec 17, 2024 · 2 comments
Open
4 tasks

Consistently name context variable #7702

DimitrisJim opened this issue Dec 17, 2024 · 2 comments
Assignees
@iIvaki
Labels
type: code hygiene Clean up code but without changing functionality or interfaces

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Dec 17, 2024 •
edited
Loading

Ref #7261 (comment)

minor nit for naming these context vars with consistency ctx/goCtx

Would be nice to use same names across the board to avoid confusion.

Should be done after #7261 and relevant PRs for it are merged.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@DimitrisJim DimitrisJim added the type: code hygiene Clean up code but without changing functionality or interfaces label Dec 17, 2024
@DimitrisJim DimitrisJim mentioned this issue Dec 17, 2024
Merged
10 tasks
@iIvaki
Copy link
Contributor

iIvaki commented Dec 17, 2024

@DimitrisJim can I do this?

@DimitrisJim
Copy link
Contributor Author

Sure, Please wait for Environment prs to land first though! Ideally, should pick this up when #7712 is closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iIvaki iIvaki

Labels
type: code hygiene Clean up code but without changing functionality or interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DimitrisJim @iIvaki