Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to cosmos-sdk v0.52 (Olympus) #7261

Merged
merged 98 commits into from
Dec 17, 2024
Merged

deps: update to cosmos-sdk v0.52 (Olympus) #7261

Show file tree
Hide file tree
Changes from 74 commits
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
a1ef65e
go mod changes
tac0turtle Sep 6, 2024
a0bf113
remove cometabci direct dep
tac0turtle Sep 6, 2024
5a331ed
fix all errors
tac0turtle Sep 8, 2024
6d49de2
appmodule & simapp cleanup
tac0turtle Sep 8, 2024
ad88b3c
08wasm fixes
tac0turtle Sep 8, 2024
fec6f52
get 08-wasm compiling
tac0turtle Sep 8, 2024
fc0f25a
another simapp
tac0turtle Sep 8, 2024
3e5029e
another simapp
tac0turtle Sep 8, 2024
10440c8
pass in environment
tac0turtle Sep 8, 2024
d779d86
fix compilation errors
tac0turtle Sep 8, 2024
2a11f2e
some fixes
tac0turtle Sep 9, 2024
d029e19
build
tac0turtle Sep 9, 2024
c055483
fix other simapps
tac0turtle Sep 9, 2024
26d765e
linting
tac0turtle Sep 9, 2024
2ee5548
remove unsed code
tac0turtle Sep 10, 2024
0832575
Merge branch 'feat/upgrade-sdk-v0.52' into marko/gomod_change
tac0turtle Sep 23, 2024
11e5c51
go mod changes
tac0turtle Sep 23, 2024
db4ab33
add pool module
tac0turtle Sep 23, 2024
da38c64
anothersimapp
tac0turtle Sep 23, 2024
455a2e8
linting fixes
tac0turtle Sep 23, 2024
471123e
protocol pool module accounts
tac0turtle Sep 23, 2024
8c99de3
callback fixes
tac0turtle Sep 23, 2024
c01a5ed
simapp fixes
tac0turtle Sep 23, 2024
16d4530
register interfaces
tac0turtle Sep 24, 2024
ab2191b
fix feeibc
tac0turtle Sep 24, 2024
4a5d564
changes++
tac0turtle Sep 24, 2024
b2978bb
Merge branch 'feat/upgrade-sdk-v0.52' into marko/gomod_change
tac0turtle Sep 24, 2024
97ce6b8
fix missed conflict
tac0turtle Sep 24, 2024
58e6cbe
fix wasm client
tac0turtle Sep 24, 2024
ba0f7ce
linting fixes
tac0turtle Sep 24, 2024
5e94346
Merge branch 'main' into marko/gomod_change
tac0turtle Oct 21, 2024
4af6896
fix tests
tac0turtle Oct 21, 2024
bb85a9a
linting
tac0turtle Oct 21, 2024
9dc1460
fix simapp tests
tac0turtle Oct 21, 2024
a073c5d
erge branch 'main' into marko/gomod_change
tac0turtle Nov 6, 2024
6ef7fc1
fix some tests
tac0turtle Nov 6, 2024
ac74c7d
fix e2e go mod
tac0turtle Nov 6, 2024
85c06e1
go mod changes
tac0turtle Nov 6, 2024
4eb9438
remove grandpa
tac0turtle Nov 6, 2024
e06d2c5
Gomod changes and minor updates (#7549)
alpe Nov 11, 2024
d9d7072
chore: use same tags for all go mods
chatton Nov 18, 2024
452a287
chore: update go mod files, revert callbacks simapp changes
chatton Nov 18, 2024
b24e6aa
chore: fix tendermint client test suite
chatton Nov 18, 2024
b02eb86
chore: fix tests in TestAnteDecoratorCheckTx
chatton Nov 19, 2024
b6e75a8
chore: fix event tests
chatton Nov 19, 2024
a9baeec
chore: fix compiler error in simapp
damiannolan Nov 19, 2024
b54b4b6
deps: update to latest of cosmossdk.io/store main to fix proofs test
damiannolan Nov 19, 2024
61aea60
chore: tidy all
chatton Nov 20, 2024
0eb8205
fix: remove ibcmock module acc from blocked addrs
damiannolan Nov 20, 2024
8c94751
chore: fix proto failures and Gov errors
chatton Nov 20, 2024
386b258
chore: fix ica test
chatton Nov 20, 2024
bfd2454
chore: fix a few compiler errs in 08-wasm
damiannolan Nov 20, 2024
0ec2d48
fix: update ica account already exists test to front run account crea…
damiannolan Nov 20, 2024
37da9f5
chore: fix ica test for address gen
damiannolan Nov 20, 2024
b75b061
Merge pull request #7580 from cosmos/cian/damian/sdk-52
damiannolan Nov 20, 2024
610ff2d
Merge branch 'main' into marko/gomod_change
damiannolan Nov 21, 2024
cec1953
chore: re-add log to returned error
chatton Nov 21, 2024
5f115f4
chore: update go mods
chatton Nov 21, 2024
d7d1713
chore: fixed build errors in wasm app.go
chatton Nov 21, 2024
a195296
chore: cleanup callbacks simapp
damiannolan Nov 21, 2024
47eb259
chore: fixing simulation functions
chatton Nov 21, 2024
6ca4a43
chore: reconfigure simd cmd and fix TestInitCmd
damiannolan Nov 21, 2024
5cf7d7e
feat: add runtime Env to icacontroller and fix v0.52 e2e tests (#7587)
damiannolan Dec 6, 2024
2a56ea4
Merge branch 'main' into marko/gomod_change
damiannolan Dec 6, 2024
7cb2628
chore: linter fixes
damiannolan Dec 6, 2024
28f2db6
lint: ignore redunant import alias
damiannolan Dec 6, 2024
6774ad5
chore: rm redudant semi-colon in tendermint.proto
damiannolan Dec 6, 2024
ad342c1
chore: rm redundant doc string regarding e2e-compatibility tests - te…
damiannolan Dec 6, 2024
58eed17
chore: update dead links
damiannolan Dec 6, 2024
a18a926
Merge branch 'main' into marko/gomod_change
damiannolan Dec 6, 2024
a16a810
Merge branch 'main' into marko/gomod_change
damiannolan Dec 11, 2024
1af3870
fix: apply fix for x/tx cosmos-sdk #22574
damiannolan Dec 12, 2024
8ea3954
Merge branch 'main' into marko/gomod_change
damiannolan Dec 12, 2024
d20e48f
Merge branch 'main' into marko/gomod_change
damiannolan Dec 12, 2024
e37253f
Merge branch 'main' into marko/gomod_change
damiannolan Dec 12, 2024
e6da172
chore: make lint-fix
damiannolan Dec 12, 2024
e093d05
fix: use hermes v1.10.4 for ci configs
damiannolan Dec 12, 2024
6fbf716
fix: apply fix for cosmos-sdk #22779 and update dependencies
damiannolan Dec 13, 2024
355b87c
fix: unpin local sdk to HEAD of release/v0.52 in simapp go.mod
damiannolan Dec 13, 2024
a1327ec
chore: revert docs/versioned_docs to main
damiannolan Dec 13, 2024
95616c7
chore: ammendments to linter configs
damiannolan Dec 16, 2024
e2b440f
chore: update var name in expected keeper
damiannolan Dec 16, 2024
ddd8136
chore: revert diffs in clienttypes/height_test
damiannolan Dec 16, 2024
fd5f4a8
chore: propagate error from event emission in icacontroller
damiannolan Dec 16, 2024
f8bd778
test: revert unnecessary diffs in test fn
damiannolan Dec 16, 2024
d119a94
chore: update comment in test chain
damiannolan Dec 16, 2024
a585ff4
Update e2e/tests/interchain_accounts/base_test.go
damiannolan Dec 16, 2024
7ca6d53
chore: nit on import aliasing
damiannolan Dec 16, 2024
b867f2b
refactor: rename instances of expected keepers from accountKeeper -> …
damiannolan Dec 16, 2024
6dc1572
chore: readd TestABCICodeDeterminism to 04-channel types
damiannolan Dec 16, 2024
57cb8e8
refactor: remove redundant AppModuleBasics
damiannolan Dec 16, 2024
de75d2c
chore: rm GetStakingKeeper api from testing app
damiannolan Dec 16, 2024
6dd955d
chore: update version in wasm dockerfile
damiannolan Dec 16, 2024
d4644d0
chore: update the go work example file version
damiannolan Dec 16, 2024
4513f7f
chore: rm UnwrapSDKContext in ica where possible
damiannolan Dec 16, 2024
6d5937c
Merge branch 'main' into marko/gomod_change
damiannolan Dec 16, 2024
3d9ad80
fix: import path in e2e from suggestion
damiannolan Dec 16, 2024
efca310
Merge branch 'main' into marko/gomod_change
damiannolan Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/callbacks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: golangci/[email protected]
with:
version: v1.57.2
version: v1.60
only-new-issues: true
args: --timeout 5m
working-directory: modules/apps/callbacks
Expand All @@ -32,12 +32,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-arch: ['amd64', 'arm', 'arm64']
go-arch: ['amd64', 'arm64']
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- name: Build callbacks-module
run: |
cd modules/apps/callbacks
Expand All @@ -49,7 +49,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- name: Go Test
run: |
cd modules/apps/callbacks
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-compatibility-workflow-call.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
repository: cosmos/ibc-go
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
cache-dependency-path: 'e2e/go.sum'
- name: Run e2e Test
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/e2e-fork.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- id: set-matrix
run: |
output=$(go run cmd/build_test_matrix/main.go)
Expand All @@ -45,7 +45,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- id: set-matrix
run: |
output=$(go run cmd/build_test_matrix/main.go)
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
cache-dependency-path: 'e2e/go.sum'
- name: Run e2e Test
run: |
Expand Down Expand Up @@ -112,7 +112,7 @@ jobs:
# - name: Setup Go
# uses: actions/setup-go@v5
# with:
# go-version: '1.22'
# go-version: '1.23'
# cache-dependency-path: 'e2e/go.sum'
# - name: Run e2e Test
# run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/e2e-test-workflow-call.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ jobs:
repository: cosmos/ibc-go
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- id: set-matrix
run: |
output=$(go run cmd/build_test_matrix/main.go)
Expand Down Expand Up @@ -215,7 +215,7 @@ jobs:
repository: cosmos/ibc-go
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
cache-dependency-path: 'e2e/go.sum'
- name: Run e2e Test
id: e2e_test
Expand Down Expand Up @@ -264,7 +264,7 @@ jobs:
repository: cosmos/ibc-go
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
cache-dependency-path: 'e2e/go.sum'
- name: Run e2e Test
id: e2e_test
Expand All @@ -278,4 +278,4 @@ jobs:
with:
name: '${{ matrix.entrypoint }}-${{ matrix.test }}'
path: e2e/diagnostics
retention-days: 5
retention-days: 5
2 changes: 1 addition & 1 deletion .github/workflows/e2e-wasm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- id: get-tag
run: |
if [ -z "${{ github.event.pull_request.number }}" ]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- id: get-tag
run: |
if [ -z "${{ github.event.pull_request.number }}" ]
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/e2emodule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
cache-dependency-path: 'e2e/go.sum'
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: golangci/[email protected]
with:
version: v1.57.2
version: v1.60
only-new-issues: true
args: --timeout 5m
working-directory: e2e/
Expand All @@ -35,7 +35,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
cache-dependency-path: 'e2e/go.sum'
- name: Go Test
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/golangci-feature.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: golangci-lint
uses: golangci/[email protected]
with:
version: v1.57.2
version: v1.60
only-new-issues: true
args: --timeout 10m
4 changes: 2 additions & 2 deletions .github/workflows/golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: golangci-lint
uses: golangci/[email protected]
with:
version: v1.57.2
version: v1.60
only-new-issues: true
args: --timeout 10m
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'

- name: Release
uses: goreleaser/goreleaser-action@v6
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- uses: technote-space/[email protected]
id: git_diff
with:
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- name: Create a file with all the pkgs
run: go list ./... | grep -v e2e > pkgs.txt
- name: Split pkgs into 4 files
Expand Down Expand Up @@ -92,7 +92,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- uses: technote-space/[email protected]
with:
PATTERNS: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/wasm-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: golangci/[email protected]
with:
version: v1.57.2
version: v1.60
only-new-issues: true
args: --timeout 10m
working-directory: modules/light-clients/08-wasm
Expand All @@ -36,7 +36,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
# Install cross compiler for ARM64. Export CC env variable.
- name: Install compiler for arm64.
run: |
Expand All @@ -55,7 +55,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'
- name: Go Test
run: |
cd modules/light-clients/08-wasm
Expand Down
14 changes: 8 additions & 6 deletions .golangci.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use more love too at some point

Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ linters:

issues:
exclude-rules:
- text: 'differs only by capitalization to method'
- text: "differs only by capitalization to method"
linters:
- revive
- text: 'Use of weak random number generator'
- text: "Use of weak random number generator"
linters:
- gosec
- linters:
Expand All @@ -61,6 +61,8 @@ linters-settings:
# Do NOT whine about the following, full explanation found in:
# https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#description-of-available-rules
rules:
- name: redundant-import-alias
disabled: true
- name: use-any
disabled: true
- name: if-return
Expand Down Expand Up @@ -109,7 +111,7 @@ linters-settings:
- name: unhandled-error
disabled: false
arguments:
- 'fmt.Printf'
- 'fmt.Print'
- 'fmt.Println'
- 'myFunction'
- "fmt.Printf"
- "fmt.Print"
- "fmt.Println"
- "myFunction"
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22-alpine3.20 as builder
FROM golang:1.23.2-alpine as builder
ARG IBC_GO_VERSION

RUN set -eux; apk add --no-cache git libusb-dev linux-headers gcc musl-dev make;
Expand Down
1 change: 0 additions & 1 deletion docs/dev/release-management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ Additionally, for the first point release of a new major or minor release branch

- Update the table of supported release lines (and End of Life dates) in [`RELEASES.md`](../../RELEASES.md): add the new release line and remove any release lines that might have become discontinued.
- Update the [list of supported release lines in README.md](../../RELEASES.md#releases), if necessary.
- Update the [e2e compatibility test matrices](https://github.com/cosmos/ibc-go/tree/main/.github/compatibility-test-matrices): add the tag for the new release and remove any tags that might not be recommended anymore.
- Update the manual [e2e `simd`](https://github.com/cosmos/ibc-go/blob/main/.github/workflows/e2e-manual-simd.yaml) test workflow:
- Remove any tags that might not be recommended anymore.
- Update docs site:
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/03-light-clients/01-developer-guide/09-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (AppModuleBasic) RegisterLegacyAminoCodec(*codec.LegacyAmino) {}

// RegisterInterfaces registers module concrete types into protobuf Any. This allows core IBC
// to unmarshal tendermint light client types.
func (AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry) {
func (AppModuleBasic) RegisterInterfaces(registry coreregistry.InterfaceRegistrar) {
RegisterInterfaces(registry)
}

Expand Down
2 changes: 1 addition & 1 deletion docs/docs/03-light-clients/04-wasm/05-governance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
...
"github.com/cosmos/cosmos-sdk/runtime"
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
govtypes "cosmossdk.io/x/gov/types"

ibcwasmkeeper "github.com/cosmos/ibc-go/modules/light-clients/08-wasm/keeper"
ibcwasmtypes "github.com/cosmos/ibc-go/modules/light-clients/08-wasm/types"
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/05-migrations/06-v4-to-v5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ The `MockEmptyAcknowledgement` type has been renamed to `EmptyAcknowledgement` (

The `TestingApp` interface in `testing` has gone through some modifications:

- The return type of the function `GetStakingKeeper` is not the concrete type `stakingkeeper.Keeper` anymore (where `stakingkeeper` is an import alias for `"github.com/cosmos/cosmos-sdk/x/staking/keeper"`), but it has been changed to the interface `ibctestingtypes.StakingKeeper` (where `ibctestingtypes` is an import alias for `""github.com/cosmos/ibc-go/v5/testing/types"`). See this [PR](https://github.com/cosmos/ibc-go/pull/2028) for more details. The `StakingKeeper` interface is defined as:
- The return type of the function `GetStakingKeeper` is not the concrete type `stakingkeeper.Keeper` anymore (where `stakingkeeper` is an import alias for `"cosmossdk.io/x/staking/keeper"`), but it has been changed to the interface `ibctestingtypes.StakingKeeper` (where `ibctestingtypes` is an import alias for `""github.com/cosmos/ibc-go/v5/testing/types"`). See this [PR](https://github.com/cosmos/ibc-go/pull/2028) for more details. The `StakingKeeper` interface is defined as:

```go
type StakingKeeper interface {
Expand Down
1 change: 1 addition & 0 deletions docs/tutorials/01-fee/04-wire-feeibc-mod.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ Next, we need to add `fee` module to the module basic manager and define its acc
stakingtypes.BondedPoolName: {authtypes.Burner, authtypes.Staking},
stakingtypes.NotBondedPoolName: {authtypes.Burner, authtypes.Staking},
govtypes.ModuleName: {authtypes.Burner},
pooltypes.ModuleName: nil,
ibctransfertypes.ModuleName: {authtypes.Minter, authtypes.Burner},
// plus-diff-line
+ ibcfeetypes.ModuleName: nil,
Expand Down
2 changes: 1 addition & 1 deletion docs/versioned_docs/version-v6.3.x/04-migrations/06-v4-to-v5.md
View file
Open in desktop
damiannolan marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ The `MockEmptyAcknowledgement` type has been renamed to `EmptyAcknowledgement` (

The `TestingApp` interface in `testing` has gone through some modifications:

- The return type of the function `GetStakingKeeper` is not the concrete type `stakingkeeper.Keeper` anymore (where `stakingkeeper` is an import alias for `"github.com/cosmos/cosmos-sdk/x/staking/keeper"`), but it has been changed to the interface `ibctestingtypes.StakingKeeper` (where `ibctestingtypes` is an import alias for `""github.com/cosmos/ibc-go/v5/testing/types"`). See this [PR](https://github.com/cosmos/ibc-go/pull/2028) for more details. The `StakingKeeper` interface is defined as:
- The return type of the function `GetStakingKeeper` is not the concrete type `stakingkeeper.Keeper` anymore (where `stakingkeeper` is an import alias for `"cosmossdk.io/x/staking/keeper"`), but it has been changed to the interface `ibctestingtypes.StakingKeeper` (where `ibctestingtypes` is an import alias for `""github.com/cosmos/ibc-go/v5/testing/types"`). See this [PR](https://github.com/cosmos/ibc-go/pull/2028) for more details. The `StakingKeeper` interface is defined as:

```go
type StakingKeeper interface {
Expand Down
2 changes: 1 addition & 1 deletion docs/versioned_docs/version-v7.8.x/03-light-clients/01-developer-guide/09-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (AppModuleBasic) RegisterLegacyAminoCodec(*codec.LegacyAmino) {}

// RegisterInterfaces registers module concrete types into protobuf Any. This allows core IBC
// to unmarshal tendermint light client types.
func (AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry) {
func (AppModuleBasic) RegisterInterfaces(registry coreregistry.InterfaceRegistrar) {
RegisterInterfaces(registry)
}

Expand Down
2 changes: 1 addition & 1 deletion docs/versioned_docs/version-v7.8.x/03-light-clients/04-wasm/05-governance.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import (
...
"github.com/cosmos/cosmos-sdk/runtime"
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
govtypes "github.com/cosmos/cosmos-sdk/x/gov/types"
govtypes "cosmossdk.io/x/gov/types"

ibcwasmkeeper "github.com/cosmos/ibc-go/modules/light-clients/08-wasm/keeper"
ibcwasmtypes "github.com/cosmos/ibc-go/modules/light-clients/08-wasm/types"
Expand Down
2 changes: 1 addition & 1 deletion docs/versioned_docs/version-v7.8.x/05-migrations/06-v4-to-v5.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ The `MockEmptyAcknowledgement` type has been renamed to `EmptyAcknowledgement` (

The `TestingApp` interface in `testing` has gone through some modifications:

- The return type of the function `GetStakingKeeper` is not the concrete type `stakingkeeper.Keeper` anymore (where `stakingkeeper` is an import alias for `"github.com/cosmos/cosmos-sdk/x/staking/keeper"`), but it has been changed to the interface `ibctestingtypes.StakingKeeper` (where `ibctestingtypes` is an import alias for `""github.com/cosmos/ibc-go/v5/testing/types"`). See this [PR](https://github.com/cosmos/ibc-go/pull/2028) for more details. The `StakingKeeper` interface is defined as:
- The return type of the function `GetStakingKeeper` is not the concrete type `stakingkeeper.Keeper` anymore (where `stakingkeeper` is an import alias for `"cosmossdk.io/x/staking/keeper"`), but it has been changed to the interface `ibctestingtypes.StakingKeeper` (where `ibctestingtypes` is an import alias for `""github.com/cosmos/ibc-go/v5/testing/types"`). See this [PR](https://github.com/cosmos/ibc-go/pull/2028) for more details. The `StakingKeeper` interface is defined as:

```go
type StakingKeeper interface {
Expand Down
2 changes: 1 addition & 1 deletion docs/versioned_docs/version-v8.5.x/03-light-clients/01-developer-guide/09-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func (AppModuleBasic) RegisterLegacyAminoCodec(*codec.LegacyAmino) {}

// RegisterInterfaces registers module concrete types into protobuf Any. This allows core IBC
// to unmarshal tendermint light client types.
func (AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry) {
func (AppModuleBasic) RegisterInterfaces(registry coreregistry.InterfaceRegistrar) {
RegisterInterfaces(registry)
}

Expand Down
Loading
Loading