Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate custom BEM to getBEM syntax #8274

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Migrate custom BEM to getBEM syntax #8274

merged 9 commits into from
Apr 25, 2024

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Mar 27, 2024 •
edited
Loading

Bring in updated getBEM name work from DS (see cfpb/design-system#1919)

Changes

  • Update to v1.0.0 of the design system.
  • Migrate custom BEM to getBEM syntax. The new syntax separates elements with a double underscore __ and modifiers with a double dash --.
  • Adds selector-class-pattern setting for BEM to stylelint.

How to test this PR

  1. PR checks should pass and the site should be the same, which is a big ask, but this touches pretty much everywhere 🙀
  2. yarn build and yarn lint should pass.

@anselmbradford anselmbradford force-pushed the ans_update_bem branch 2 times, most recently from b6d48e5 to be2ff75 Compare March 29, 2024 22:58
@anselmbradford anselmbradford force-pushed the ans_update_bem branch 6 times, most recently from 0c5801d to bb8678f Compare April 5, 2024 14:07
@anselmbradford anselmbradford force-pushed the ans_update_bem branch 5 times, most recently from 5becf03 to eed8b06 Compare April 16, 2024 15:38
@anselmbradford anselmbradford marked this pull request as ready for review April 16, 2024 15:39
@anselmbradford anselmbradford requested a review from a team April 16, 2024 15:39
@anselmbradford anselmbradford force-pushed the ans_update_bem branch 2 times, most recently from 5a3e04a to edbbbbb Compare April 16, 2024 17:42
@anselmbradford anselmbradford force-pushed the ans_update_bem branch 2 times, most recently from 1b46fee to e46c842 Compare April 18, 2024 15:34
@anselmbradford anselmbradford force-pushed the ans_update_bem branch 2 times, most recently from 2b617c8 to f147bd4 Compare April 24, 2024 12:58
@contolini contolini self-requested a review April 24, 2024 17:05
contolini
contolini approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@anselmbradford anselmbradford added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 3d1f41e Apr 25, 2024
17 checks passed
@anselmbradford anselmbradford deleted the ans_update_bem branch April 25, 2024 22:15
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
willbarton added a commit that referenced this pull request Apr 29, 2024
@willbarton
Fix feature cards by swapping files around
8059942 
#8274 seems like it swapped the contents of these two files around. This change switches them back.
@willbarton willbarton mentioned this pull request Apr 29, 2024
Merged
2 tasks
This was referenced Apr 30, 2024
Merged
Merged
Merged
Merged
@wpears wpears mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@contolini contolini contolini approved these changes

@paulhyland paulhyland Awaiting requested review from paulhyland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anselmbradford @contolini