Review fixes

cfpb · Apr 24, 2024 · 2b617c8 · 2b617c8
1 parent 391aa6d
commit 2b617c8
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 16 deletions.
diff --git a/cfgov/ask_cfpb/jinja2/ask-cfpb/answer-page.html b/cfgov/ask_cfpb/jinja2/ask-cfpb/answer-page.html
@@ -17,7 +17,7 @@
 {%- endblock css %}
 
 {% block content_modifiers -%}
-    {{ super() }} ask-cfpb-page ask-cfpb-page__answer
+    {{ super() }} ask-cfpb-page ask-cfpb-page--answer
 {%- endblock %}
 
 {% block content_main %}

diff --git a/cfgov/unprocessed/css/molecules/info-unit.less b/cfgov/unprocessed/css/molecules/info-unit.less
@@ -7,10 +7,10 @@
     It shouldn't be used on it's own.
  */
 .u-info-unit-base() {
-  &_image {
+  &__image {
     display: block;
     margin-right: auto;
-    margin-bottom: unit((@grid_gutter-width / 2) / @base-font-size-px, em);
+    margin-bottom: unit(@grid_gutter-width / 2 / @base-font-size-px, em);
     margin-left: auto;
     background-size: cover;
 
@@ -20,13 +20,13 @@
 
       // Desktop and above.
       .respond-to-min(@bp-med-min, {
-        width: unit( @m-info-unit_img__lg / @base-font-size-px, em );
-        height: unit( @m-info-unit_img__lg / @base-font-size-px, em );
+        width: unit(@m-info-unit_img__lg / @base-font-size-px, em);
+        height: unit(@m-info-unit_img__lg / @base-font-size-px, em);
       });
     }
   }
 
-  &_heading-link {
+  &__heading-link {
     display: block;
 
     .u-link--colors( var(--black), var(--pacific-80) );
@@ -73,7 +73,7 @@
 
   // Hide image on print.
   .respond-to-print( {
-    &_image {
+    &__image {
       display: none;
     }
   });

diff --git a/cfgov/unprocessed/css/molecules/tags.less b/cfgov/unprocessed/css/molecules/tags.less
@@ -78,7 +78,7 @@
     }
 
     // Add bottom border to last tag.
-    &_item:last-child {
+    &__item:last-child {
       // This needs to appear after border-bottom-width: 0;
       .m-tags__tag {
         border-bottom: 1px dotted var(--gold-80);

diff --git a/cfgov/unprocessed/css/on-demand/ask.less b/cfgov/unprocessed/css/on-demand/ask.less
@@ -206,13 +206,13 @@
   .answer-module {
     border-top: 3px solid var(--green);
     border-bottom: 1px solid @block--border-bottom;
-    padding: unit((@grid_gutter-width / 2) / @base-font-size-px, em) 0;
+    padding: unit(@grid_gutter-width / 2 / @base-font-size-px, em) 0;
     margin: unit(@grid_gutter-width / @base-font-size-px, em) 0;
     color: var(--gray);
 
     // Tablet and above.
     .respond-to-min(@bp-sm-min, {
-      padding: unit( ( @grid_gutter-width / 2 ) / @base-font-size-px, em );
+      padding: unit(@grid_gutter-width / 2 / @base-font-size-px, em );
     });
 
     // Desktop and above.
@@ -227,7 +227,7 @@
     h6 {
       .heading-5();
       margin-top: 0;
-      margin-bottom: unit((@grid_gutter-width / 3) / @base-font-size-px, em);
+      margin-bottom: unit(@grid_gutter-width / 3 / @base-font-size-px, em);
     }
 
     p:last-child,
@@ -251,7 +251,7 @@
   .question-categories {
     // Tablet and above.
     .respond-to-min(@bp-sm-min, {
-      padding-right: unit( @grid_gutter-width / 2 / @base-font-size-px, em );
+      padding-right: unit(@grid_gutter-width / 2 / @base-font-size-px, em);
     });
   }
 
@@ -308,11 +308,11 @@
   }
 
   .question__summary {
-    padding: unit((@grid_gutter-width / 2) / @base-font-size-px, em) 0;
+    padding: unit(@grid_gutter-width / 2 / @base-font-size-px, em) 0;
 
     // Desktop and above.
     .respond-to-min(@bp-med-min, {
-      padding:  unit( @grid_gutter-width / @base-font-size-px, em ) 0;
+      padding:  unit(@grid_gutter-width / @base-font-size-px, em) 0;
     });
 
     .question__title a {

diff --git a/cfgov/v1/jinja2/v1/includes/molecules/social-media.html b/cfgov/v1/jinja2/v1/includes/molecules/social-media.html
@@ -68,7 +68,7 @@
 {% set twitter_text = ( value.twitter_text or blurb ) | urlencode %}
 
 <div class="m-social-media
-            m-social-media__{{ 'share' if is_share_view else 'follow' }}">
+            m-social-media--{{ 'share' if is_share_view else 'follow' }}">
     {% if is_share_view %}
         <div class="h5 m-social-media__heading">
             {% if is_printable -%}

diff --git a/docs/atomic-structure.md b/docs/atomic-structure.md
@@ -123,7 +123,7 @@ Prefixed with `o-` in class names.
 .o-expandable {
     position: relative;
 
-    &_header {
+    &__header {
         padding: 0;
         border: 0;
         …