Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video player modifiers #8368

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix video player modifiers #8368

merged 1 commit into from
May 1, 2024

Conversation

anselmbradford
Copy link
Member

Additional cleanup followup to #8274

Video player o-video-player__video-container__flexible should be o-video-player__video-container--flexible and was messing up the player dimensions.

Changes

  • Fix video player modifiers (o-video-player__video-container--flexible and o-video-player--youtube)

How to test this PR

  1. Visit http://localhost:8000/ask-cfpb/do-buy-now-pay-later-bnpl-loans-have-fees-en-2118/ and play the video. It should be full sized.

Screenshots

Before:
Screenshot 2024-05-01 at 10 51 01 AM

After:
Screenshot 2024-05-01 at 10 58 10 AM

@anselmbradford anselmbradford assigned mistergone and wpears and unassigned mistergone and wpears May 1, 2024
@anselmbradford anselmbradford enabled auto-merge May 1, 2024 16:35
@anselmbradford anselmbradford added this pull request to the merge queue May 1, 2024
Merged via the queue into main with commit e2dcb18 May 1, 2024
12 checks passed
@anselmbradford anselmbradford deleted the ans_video_bem branch May 1, 2024 20:51
This was referenced May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants