Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): replace autoware_auto_mapping_msg with autoware_map_msg #688

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

cyn-liu
Copy link
Contributor

@cyn-liu cyn-liu commented Nov 15, 2023

Description

merge to autoware-msg branch:
replace autoware_auto_mapping_msg/msg/HADMapBin with autoware_map_msgs/msg/ LaneletMapBin

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@cyn-liu cyn-liu requested a review from beginningfan November 15, 2023 10:28
@cyn-liu cyn-liu changed the title feat(autoware_launch): remove autoware auto mapping msg feat(autoware_launch): replace autoware-auto-mapping-msg to autoware-map-msg Nov 15, 2023
@cyn-liu cyn-liu changed the title feat(autoware_launch): replace autoware-auto-mapping-msg to autoware-map-msg feat(autoware_launch): replace autoware-auto-mapping-msg with autoware-map-msg Nov 15, 2023
@cyn-liu cyn-liu requested a review from kminoda November 15, 2023 12:18
@kminoda
Copy link
Contributor

kminoda commented Nov 15, 2023

You want me to review this? I am not fully aware of the context, e.g. what the autoware_msg branch is intended for, so may not be able to review correctly.

@cyn-liu
Copy link
Contributor Author

cyn-liu commented Nov 16, 2023

You want me to review this? I am not fully aware of the context, e.g. what the autoware_msg branch is intended for, so may not be able to review correctly.

PR background: autowarefoundation/autoware#3972

you ignore this PR, we just merge to autoware_msg branch, but we won't merge until all the msgs have been modified and propose PR.

@cyn-liu cyn-liu removed the request for review from kminoda November 16, 2023 04:03
@cyn-liu cyn-liu changed the title feat(autoware_launch): replace autoware-auto-mapping-msg with autoware-map-msg feat(autoware_launch): replace autoware_auto_mapping_msg with autoware_map_msg Nov 16, 2023
soblin added a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
* feat(autoware_launch): add traffic protected level for amber color in intersection (autowarefoundation#588)

* feat(autoware_launch): add traffic protected level for amber color in intersection

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>

* feat(intersection): ignore decelerating vehicle on amber traffic light (autowarefoundation#635)

* feat(intersection): ignore decelerating vehicle on amber traffic light

Signed-off-by: Mamoru Sobue <[email protected]>

* tuning

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
@cyn-liu cyn-liu merged commit d995e45 into autoware_msg Nov 22, 2023
14 of 15 checks passed
@cyn-liu cyn-liu deleted the remove_autoware_auto_mapping_msg branch November 22, 2023 09:37
takayuki5168 referenced this pull request in tier4/autoware_launch Nov 26, 2023
* feat(autoware_launch): add traffic protected level for amber color in intersection (#588)

* feat(autoware_launch): add traffic protected level for amber color in intersection

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

* update

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>

* feat(intersection): ignore decelerating vehicle on amber traffic light (#635)

* feat(intersection): ignore decelerating vehicle on amber traffic light

Signed-off-by: Mamoru Sobue <[email protected]>

* tuning

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Mamoru Sobue <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
mitsudome-r added a commit that referenced this pull request Jun 4, 2024
* feat(autoware_launch): replace autoware_auto_mapping_msg with autoware_map_msg (#688)

feat(autoware_launch): remove autoware auto mapping msg

Signed-off-by: liu cui <[email protected]>

* fix: planning_msg (#717)

fix:planning_msg

Signed-off-by: jack.song <[email protected]>

* feat(autoware_launch): replace autoware_control_msg with autoware_con… (#725)

feat(autoware_launch): replace autoware_control_msg with autoware_control_msg

Signed-off-by: NorahXiong <[email protected]>

* feat(autoware_launch): replace autoware_auto_vehicle_msgs with autoware_vehicle_msgs

Signed-off-by: liu cui <[email protected]>

* fix(topics.yaml): fix AUTO button bug

Signed-off-by: liu cui <[email protected]>

* feat(autoware_launch): rename autoware_auto_perception_rviz_plugin to autoware_perception_rviz_plugin

Signed-off-by: Ryohsuke Mitsudome <[email protected]>

* feat: rename TrafficSignal messages to TrafficLightGroup

Signed-off-by: liu cui <[email protected]>

---------

Signed-off-by: liu cui <[email protected]>
Signed-off-by: jack.song <[email protected]>
Signed-off-by: NorahXiong <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: cyn-liu <[email protected]>
Co-authored-by: shulanbushangshu <[email protected]>
Co-authored-by: NorahXiong <[email protected]>
Co-authored-by: liu cui <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants